Skip to content

pathname: build eager-init type objects once, not per allocation #23267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeMcQuaid merged 2 commits into from
Jul 22, 2026
+14 −6
Merged

pathname: build eager-init type objects once, not per allocation #23267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1edb0a9
Refactor: use type aliases for nilable types in EagerInitializeExtension
hyuraku Jul 22, 2026
c7f5bb0
Re-run CI
hyuraku Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions Library/Homebrew/extend/pathname/eager_initialize_extension.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,22 @@ module EagerInitializeExtension

requires_ancestor { Pathname }

# These aliases hoist the `T.nilable(...)` type objects out of the hot path.
# `#initialize` runs on every {Pathname} allocation, and with runtime
# checks disabled `T.let` discards its type argument, so evaluating
# `T.nilable(...)` inline would rebuild the same type objects each time.
NilableString = T.type_alias { T.nilable(String) }
NilableInteger = T.type_alias { T.nilable(Integer) }
NilableStringArray = T.type_alias { T.nilable(T::Array[String]) }

sig { params(args: T.untyped).void }
def initialize(*args)
@magic_number = T.let(nil, T.nilable(String))
@file_type = T.let(nil, T.nilable(String))
@zipinfo = T.let(nil, T.nilable(T::Array[String]))
@which_install_info = T.let(nil, T.nilable(String))
@disk_usage = T.let(nil, T.nilable(Integer))
@file_count = T.let(nil, T.nilable(Integer))
@magic_number = T.let(nil, NilableString)
@file_type = T.let(nil, NilableString)
@zipinfo = T.let(nil, NilableStringArray)
@which_install_info = T.let(nil, NilableString)
@disk_usage = T.let(nil, NilableInteger)
@file_count = T.let(nil, NilableInteger)
super
end
end
Loading