firefly: update ldflags with new org urls - #294306
Conversation
|
Thanks for contributing to Homebrew! 馃帀 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
03728e5 to
18d08d4
Compare
|
I think we could apply this after v1.5.0 released. |
|
Org change is maybe the reason of this |
|
I did see for some reason the SHA had changed in a previous PR and not sure why @daeho-ro |
|
The git manual says re-tagging is "the insane thing" to do. And research also shows it鈥檚 a growing problem for anyone using your software: https://arxiv.org/abs/2606.31354. Could you please check internally why the shasum changed? Otherwise we should disable the software until we're sure that it has not been compromised. |
|
@SMillerDev My suspection is url changed by org name change. |
|
Could be, could also be compromised. We can't just rule out the worst case scenario because there is a best case scenario. We wouldn't be very good protectors of our users if we did. |
|
Not compromised @SMillerDev, I am maintainer of Hyperledger FireFly and lead the release process. I understand your concern, let me double check if due to the org move the release SHA changes - we did not retag |
|
@SMillerDev Verified that this is not a re-tag or compromise. The v1.4.0 tag still points to the exact same commit it always has: I downloaded the archive from the new org URL and diffed its contents against git archive v1.4.0 from a local clone and it's byte-identical, zero differences. The sha256 change is purely GitHub regenerating the auto-generated tarball bytes (gzip/tar metadata) on the archive endpoint this was a change in Github on how they generate the checksum take a look at a similar pkg that had the same issue in Homebrew spack/spack#5411 . This change is likely due to the org move We should not be relying on these auto generate resource paths |
|
A very good explanation of the issue can be found here libgit2/libgit2#4343 (comment) |
|
Thanks for the investigation @EnriqueL8, you can never be too careful with supply chain security these days. |
|
@SMillerDev Absolutely agree |
|
What are the next steps on this one then :) |
|
Please rebase it to resolve conflicts with |
|
Also, please note that upstream rename of Go module is not yet released and included in current 1.4.0 release, thats's why test here is failing with: It seems to be coming in upcoming 1.5.0: https://github.com/hyperledger-firefly/cli/releases/tag/v1.5.0-rc.1 |
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
456c7aa to
4181ee3
Compare
|
Good, now we just need to wait for the 1.5.0 release, which will actually need the new |
|
Superseded by |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?