Skip to content

firefly: update ldflags with new org urls - #294306

Closed
EnriqueL8 wants to merge 1 commit into
Homebrew:mainfrom
EnriqueL8:firefly-org-change
Closed

firefly: update ldflags with new org urls#294306
EnriqueL8 wants to merge 1 commit into
Homebrew:mainfrom
EnriqueL8:firefly-org-change

Conversation

@EnriqueL8

Copy link
Copy Markdown

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@github-actions github-actions Bot added the go Go use is a significant feature of the PR or issue label Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for contributing to Homebrew! 馃帀 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 21, 2026
@EnriqueL8
EnriqueL8 force-pushed the firefly-org-change branch from 03728e5 to 18d08d4 Compare July 21, 2026 14:23
@daeho-ro

Copy link
Copy Markdown
Member

I think we could apply this after v1.5.0 released.

@daeho-ro

Copy link
Copy Markdown
Member

Org change is maybe the reason of this

@EnriqueL8

Copy link
Copy Markdown
Author

I did see for some reason the SHA had changed in a previous PR and not sure why @daeho-ro

@SMillerDev

Copy link
Copy Markdown
Member

The git manual says re-tagging is "the insane thing" to do. And research also shows it鈥檚 a growing problem for anyone using your software: https://arxiv.org/abs/2606.31354. Could you please check internally why the shasum changed? Otherwise we should disable the software until we're sure that it has not been compromised.

@daeho-ro

Copy link
Copy Markdown
Member

@SMillerDev My suspection is url changed by org name change.

@SMillerDev

Copy link
Copy Markdown
Member

Could be, could also be compromised. We can't just rule out the worst case scenario because there is a best case scenario. We wouldn't be very good protectors of our users if we did.

@EnriqueL8

EnriqueL8 commented Jul 23, 2026

Copy link
Copy Markdown
Author

Not compromised @SMillerDev, I am maintainer of Hyperledger FireFly and lead the release process. I understand your concern, let me double check if due to the org move the release SHA changes - we did not retag

@EnriqueL8

EnriqueL8 commented Jul 23, 2026

Copy link
Copy Markdown
Author

@SMillerDev Verified that this is not a re-tag or compromise. The v1.4.0 tag still points to the exact same commit it always has:

git ls-remote --tags https://github.com/hyperledger-firefly/cli.git v1.4.0
52ea718c11ec8965a78b2b1de4bbb4905dbdbb21  refs/tags/v1.4.0

I downloaded the archive from the new org URL and diffed its contents against git archive v1.4.0 from a local clone and it's byte-identical, zero differences. The sha256 change is purely GitHub regenerating the auto-generated tarball bytes (gzip/tar metadata) on the archive endpoint this was a change in Github on how they generate the checksum take a look at a similar pkg that had the same issue in Homebrew spack/spack#5411 . This change is likely due to the org move

We should not be relying on these auto generate resource paths (/org/repo/archive/... and instead move to actual release ones.

@EnriqueL8

Copy link
Copy Markdown
Author

A very good explanation of the issue can be found here libgit2/libgit2#4343 (comment)

@SMillerDev

Copy link
Copy Markdown
Member

Thanks for the investigation @EnriqueL8, you can never be too careful with supply chain security these days.

@EnriqueL8

Copy link
Copy Markdown
Author

@SMillerDev Absolutely agree

@EnriqueL8

Copy link
Copy Markdown
Author

What are the next steps on this one then :)

@stefanb

stefanb commented Jul 26, 2026

Copy link
Copy Markdown
Member

Please rebase it to resolve conflicts with

@stefanb

stefanb commented Jul 26, 2026

Copy link
Copy Markdown
Member

Also, please note that upstream rename of Go module

is not yet released and included in current 1.4.0 release, thats's why test here is failing with:

  ==> /home/linuxbrew/.linuxbrew/Cellar/firefly/1.4.0/bin/firefly version --short
  Error: firefly: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected /1\.4\.0/ to match "(devel)\n".

It seems to be coming in upcoming 1.5.0: https://github.com/hyperledger-firefly/cli/releases/tag/v1.5.0-rc.1

@github-actions github-actions Bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 27, 2026
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8
EnriqueL8 force-pushed the firefly-org-change branch from 456c7aa to 4181ee3 Compare July 27, 2026 10:23
@github-actions github-actions Bot removed automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 27, 2026
@stefanb

stefanb commented Jul 27, 2026

Copy link
Copy Markdown
Member

Good, now we just need to wait for the 1.5.0 release, which will actually need the new ldflags.

@stefanb stefanb added the superseded PR was replaced by another PR label Aug 4, 2026
@stefanb

stefanb commented Aug 4, 2026

Copy link
Copy Markdown
Member

Superseded by

@stefanb stefanb closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Go use is a significant feature of the PR or issue homepage superseded PR was replaced by another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants