[Store] decouple DRAM decisions from metrics - #3
Draft
Hubert-Zhu wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements a focused first slice of upstream RFC #3158.
MasterMetricManager.NoF eviction and the
SsdMetricsProviderrename remain out of scope for this draft.Module
mooncake-store)Type of Change
How Has This Been Tested?
Test commands:
git diff --cached --check rg -n 'get_global_mem_used_ratio' mooncake-store/src mooncake-store/include ./scripts/code_format.sh --staged /usr/bin/clang++ -std=c++20 -fsyntax-only -I./mooncake-store/include -I./mooncake-common/include mooncake-store/src/segment.cppTest results:
Checklist
./scripts/code_format.sh(clang-format 20 unavailable)pre-commit run --all-filesand all hooks pass (pre-commit unavailable)AI Assistance Disclosure
Codex helped trace the allocator/metrics dependency, implement the focused change, and add tests. The human submitter should review and understand every changed line before any upstream submission.