Updated for v73, also a couple fixes.#190
Open
pacoito123 wants to merge 6 commits intoIAmBatby:mainfrom
Open
Conversation
- Updated game assemblies to v73. - Updated Netcode patching for Unity 2022.3.62f2 and NGO 1.12.0 versions. - NetcodePatcher version 4.4.1+ is needed to recompile the project. - Added PrivateAssets flag to some package references.
- Singleton classes NetworkBundleManager and LethalLevelLoaderNetworkManager are now destroyed upon creating a new instance (after a lobby reload), which then becomes the 'main' one. - Avoids old instances persisting and having their Initialize() method called on every lobby reload. - Not sure if the way I did it is the best way to go about it, but it's a possible solution. - Fixed tangential issue where the currently-routed moon's bundle unloads immediately after reloading the save file. - The bundle that was last loaded now remains loaded all throughout the lobby reload process, unless specifically loading a save file (or joining a lobby) that's routed to a different moon. - Avoids having to unload/reload the current moon's bundle when simply reloading the lobby, but it's likely a pretty negligible performance improvement. - Tested in LAN and bundles seemed to load/unload accordingly across various edge cases!
- I was under the impression things just wouldn't be backwards-compatible at all but I was wrong, and I'm not really using the new RPCs any differently so might as well keep compatibility with v72 and below.
- Fixed ExtendedUnlockableItems being registered more than once. - Only needs to be done once, not every lobby reload (like other Terminal things). - I'd talked about this issue months ago but forgor... - Fixed ExtendedUnlockableItem terminal data not actually being created... - ...and ExtendedBuyableVehicle terminal data being created twice. - Tactical blunder; true buffoonery. - Fixed that one AND sign that was meant to be an OR sign.
Collaborator
Author
|
(Did not mean to close the PR, whoops) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Fixes
Should probably be moved to its own branch since it can't be automatically merged, and the changes are minor.
(Also in one of the commits I mention Netcode being backwards-compatible with v72, this is in fact NOT the case and I was deceived by misinformation!)