feat(notifier): render portal URL as clickable hyperlink in email body#105
feat(notifier): render portal URL as clickable hyperlink in email body#105anup-kodlekere wants to merge 1 commit into
Conversation
- Switch email body template from plain text to HTML - Add <a href> anchor around "IBM® Power® Access Cloud" portal text - Read portal URL from PORTAL_URL env var - Validate PORTAL_URL is set on event-notifier startup Signed-off-by: anup-kodlekere <anup.kodlekere@ibm.com>
| Generated at: {{ .Event.CreatedAt.Format "Jan 02, 2006 15:04:05 UTC" }} | ||
| <br><br> | ||
| Thanks,<br> | ||
| IBM® Power®; Access Cloud Team. |
There was a problem hiding this comment.
I think this should be IBM® Power® Access Cloud Team right
|
Thanks for the PR @anup-kodlekere . But this needs to be validated to see if the formatting works properly or not in the email body. And also in out last testing we saw that the url will be huge as it might need to be whitelisted from security team for that to be displayed as IBM® Power® Access Cloud portal. |
|
Okay, thanks for the context. I cannot comment about the security team's assertions but I can certainly test this (with a minimal reproducible instead of deploying entire PAC) and update the results here. Does that sound good? |
Sure, you can try that |
2 participants
This PR introduces a
PORTAL_URLenvironment variable to embed a clickable hyperlink to the IBM® Power® Access Cloud portal within the email body. The email template has been migrated from plain text to HTML, and the mail content type has been updated accordingly.With this update, the event-notifier also checks for
PORTAL_URLenv var to be available at event-notifier startup.Closes #84