feat(connectors): add Data Source Connectors landing page - #1269
Open
Niranjan-J-Joshi wants to merge 7 commits into
Open
feat(connectors): add Data Source Connectors landing page#1269Niranjan-J-Joshi wants to merge 7 commits into
Niranjan-J-Joshi wants to merge 7 commits into
Conversation
Signed-off-by: Niranjan Joshi <Niranjan.Joshi1@ibm.com>
prachikurade1
requested changes
Aug 18, 2026
Signed-off-by: Niranjan Joshi <Niranjan.Joshi1@ibm.com>
ryanmarc
reviewed
Aug 18, 2026
ryanmarc
requested changes
Aug 18, 2026
Signed-off-by: Niranjan Joshi <Niranjan.Joshi1@ibm.com>
ryanmarc
approved these changes
Aug 18, 2026
ryanmarc
reviewed
Aug 19, 2026
|
|
||
| const visibleHeaders = getVisibleHeaders(HEADERS, state.visibleColumns); | ||
|
|
||
| const paginatedRows = filteredRows; |
Collaborator
There was a problem hiding this comment.
What is the purpose of this const? it's just an alias to filtered rows and creates a new variable with the same data.
ryanmarc
reviewed
Aug 19, 2026
| @@ -0,0 +1,48 @@ | |||
| import type { | |||
Collaborator
There was a problem hiding this comment.
The layering of this seems inverted. The
This file imports its types from components/DataSourceConnectorsTable/types. If these are API responses, should they be moved to types/api.types?
Contributor
Author
There was a problem hiding this comment.
Moved types related to api responses to api.types.ts
ryanmarc
requested changes
Aug 19, 2026
Signed-off-by: Niranjan Joshi <Niranjan.Joshi1@ibm.com>
Signed-off-by: Niranjan Joshi <Niranjan.Joshi1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Connectors page and DataSourceConnectorsTable component to display data source connectors. The page currently uses mock data until the backend API is available.
Changes
New:
DataSourceConnectorsTableLocation:
ui/catalog/src/components/DataSourceConnectorsTable/A Carbon
DataTablewith:name,status,type,services,messages)Updated:
CellRenderers.tsxAdded support for:
connectedofflinestatuses in the shared
StatusCell.Shared Components Used
The Connectors table is built using the shared table framework and reuses:
useAutoRefreshuseCSVExportuseExportToastAutoDismissTableToolbarActionsTableToastsTableEmptyStatesExportModalhandleSharedTableActionisSharedTableActionfilterRowsBySearchgetVisibleHeadersScreenshots