AISERVICES-1383 added async extraction background worker implementation - #1278
Open
manalilatkar wants to merge 1 commit into
Open
AISERVICES-1383 added async extraction background worker implementation#1278manalilatkar wants to merge 1 commit into
manalilatkar wants to merge 1 commit into
Conversation
Signed-off-by: Manali Latkar <manali.latkar@ibm.com>
dharaneeshvrd
left a comment
dharaneeshvrd
left a comment
Member
There was a problem hiding this comment.
I see cleanup_staging_directory getting called at multiple occasions, why not call once via finally?
Otherwise overall lgtm since its same as the previous implementation.
Let's ensure to reuse the functionalities via a common method when you implement the batch processing.
| # Fetch the job row so we know the schema_id and document name. | ||
| job_row = db_repo.get_job_by_id(job_id) | ||
| if job_row is None: | ||
| logger.error(f"Job {job_id} not found in DB at worker start; aborting.") |
Member
There was a problem hiding this comment.
dont you need to update the failure on db as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: