refactor: extract shared StepOne component across both deploy flows - #1279
Open
pranithraoibm wants to merge 17 commits into
Open
refactor: extract shared StepOne component across both deploy flows#1279pranithraoibm wants to merge 17 commits into
pranithraoibm wants to merge 17 commits into
Conversation
…state Signed-off-by: Pranith Rao <pranith.rao@ibm.com>
…rapper UI Signed-off-by: Pranith Rao <pranith.rao@ibm.com>
Signed-off-by: Pranith Rao <pranith.rao@ibm.com>
Signed-off-by: Pranith Rao <pranith.rao@ibm.com>
Contributor
Author
|
@ryanmarc FYI this PR has changes from PR7 and PR 8a as well. |
ryanmarc
reviewed
Aug 18, 2026
ryanmarc
requested changes
Aug 18, 2026
Signed-off-by: Pranith Rao <pranith.rao@ibm.com>
Signed-off-by: Pranith Rao <pranith.rao@ibm.com>
ryanmarc
reviewed
Aug 19, 2026
Signed-off-by: Pranith Rao <pranith.rao@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharedStepOnetoShared/steps/which receives all data as props, renders name, version, and component dropdowns with model/provider toggle and error bannerDAStepOne.tsx, delegates rendering to SharedStepOne, retains DA-specific provider deduplication and default model seeding logicServicesStepOne.tsx, delegates rendering to SharedStepOne, moves default model seeding useEffect here from the root (was ServicesDeployFlow)onComponentErrorto BaseStepProps in Shared/types.ts; removed onSchemaError from DA's local StepPropshasComponentErrorstate + gate to ServicesDeployFlow which was already present in DA, now both flows block Next on component load failure