[BYOS] Reload Catalog Items and integrate with APIs - #1301
Open
mayuka-c wants to merge 5 commits into
Open
Conversation
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
…m assets Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
mayuka-c
marked this pull request as ready for review
August 21, 2026 12:00
yussufsh
reviewed
Aug 21, 2026
| ctx := context.Background() | ||
|
|
||
| if err := svc.catalogReloader.Reload(ctx); err != nil { | ||
| svc.markFailed(ctx, fixedID, err.Error()) |
Member
There was a problem hiding this comment.
Why is it marking it as failed in the test?
Member
Author
There was a problem hiding this comment.
This is just a DB mocking. svc.markFailed calls the method defined at line 1463 which does the update of capturedFailUpdate Status to failed
Member
There was a problem hiding this comment.
I am confused. On looking closely, I think this should have been handled in the service itself.
markFailed is getting called in ProcessBundle() but not getting called in ReplaceBundle() and DeleteBundle().
Don't we need to update the row.ID during the replace flow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note:
catalog.NewCatalogProvider(nil)) which would be fixed when we move to using APIs as CLI cannot directly access the assets present inside volumes (Will be taken up later)