fix: interpreter of StringInterpolationExpr added additional spaces#1740
Open
slisson wants to merge 1 commit intomaintenance/mps20251from
Open
fix: interpreter of StringInterpolationExpr added additional spaces#1740slisson wants to merge 1 commit intomaintenance/mps20251from
StringInterpolationExpr added additional spaces#1740slisson wants to merge 1 commit intomaintenance/mps20251from
Conversation
It produced additional spaces around instances of `InterpolExprWord`. The main issue is is that the produced string doesn't match what is shown in the editor. Even if this was intended, there would be no way to specify a string that doesn't have spaces around `InterpolExprWord` instances. That's why this has to be a bug. If the user wants these spaces, they should be typed explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It produced additional spaces around instances of
InterpolExprWord.The main issue is is that the produced string doesn't match what is shown in the editor.
Even if this was intended, there would be no way to specify a string that doesn't have spaces around
InterpolExprWordinstances. That's why this has to be a bug. If the user wants these spaces,they should be typed explicitly.