Skip to content

[Fix] UI 0047403: HTML validator: Use role='group' for tree-containing slates#11244

Closed
fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
fhelfer:ui/mantis/47403
Closed

[Fix] UI 0047403: HTML validator: Use role='group' for tree-containing slates#11244
fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
fhelfer:ui/mantis/47403

Conversation

@fhelfer
Copy link
Contributor

@fhelfer fhelfer commented Mar 11, 2026

Problem: The UI Component documentation tool window triggered HTML validator errors: role="tree" and role="treeitem" are not allowed inside role="menu" (only menuitem, menuitemcheckbox, etc. are valid).

Solution:

  • Add role="group" as an allowed ARIA role for Slates (valid container for tree content)
  • Switch UI Component documentation from Tool to TreeTool so it uses the TreeToolItemRenderer
  • TreeToolItemRenderer sets role="group" on its slate
  • Main Bar Renderer no longer overwrites an existing ARIA role on slates

https://mantis.ilias.de/view.php?id=47403

@oliversamoila
Copy link
Contributor

Hello @thibsy,
Could you please take this over directly, check it and, ideally, integrate it into Release 11 and Trunk. You will also need to decide whether Release 10 is applicable.

Best regards,
Oliver

@thibsy thibsy added the php Pull requests that update Php code label Mar 11, 2026
Copy link
Member

@chfsx chfsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in GS are fine, thanks!

Copy link
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fhelfer,

Thx a lot for the Bugfix.

Please help me answer the following questions:

  • Isn't this issue addressed by removing the aria-role entirely from MainControls\Slate\Legacy, as proposed in #11014?

Kind regards,
@thibsy (as UI coordinator)

@fhelfer
Copy link
Contributor Author

fhelfer commented Mar 13, 2026

@thibsy, you are right i must have missed that i already provided a PR for the same issue.
I think this solution might be the better approach to solving this, rather that just removing the aia-role completely

@thibsy
Copy link
Contributor

thibsy commented Mar 13, 2026

@fhelfer no I think we should stick with #11014, because as mentioned there, we cannot safely tell what role is actually suitable. And, since we do not want to push design decisions like that onto our consumers in general, I think its best to just leave it out. We should rather tackle the underlying issue, that we do not yet have semantic (enough) components for use-cases like this.

I leave this PR open until we have verified that the other PR does indeed solve both issues.

@thibsy
Copy link
Contributor

thibsy commented Mar 13, 2026

@oliversamoila confirmed, thx! I therefore close this.

@thibsy thibsy closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix kitchen sink php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants