[Fix] UI 0047403: HTML validator: Use role='group' for tree-containing slates#11244
[Fix] UI 0047403: HTML validator: Use role='group' for tree-containing slates#11244fhelfer wants to merge 2 commits intoILIAS-eLearning:release_11from
Conversation
|
Hello @thibsy, Best regards, |
chfsx
left a comment
There was a problem hiding this comment.
The changes in GS are fine, thanks!
|
@thibsy, you are right i must have missed that i already provided a PR for the same issue. |
|
@fhelfer no I think we should stick with #11014, because as mentioned there, we cannot safely tell what role is actually suitable. And, since we do not want to push design decisions like that onto our consumers in general, I think its best to just leave it out. We should rather tackle the underlying issue, that we do not yet have semantic (enough) components for use-cases like this. I leave this PR open until we have verified that the other PR does indeed solve both issues. |
|
@oliversamoila confirmed, thx! I therefore close this. |
Problem: The UI Component documentation tool window triggered HTML validator errors:
role="tree"androle="treeitem"are not allowed insiderole="menu"(only menuitem, menuitemcheckbox, etc. are valid).Solution:
role="group"as an allowed ARIA role for Slates (valid container for tree content)TooltoTreeToolso it uses the TreeToolItemRendererrole="group"on its slatehttps://mantis.ilias.de/view.php?id=47403