Skip to content

Project The Lippie Factory#2

Open
Andreea2194 wants to merge 3 commits into
ITSchool-Web-Heroines:mainfrom
Andreea2194:main
Open

Project The Lippie Factory#2
Andreea2194 wants to merge 3 commits into
ITSchool-Web-Heroines:mainfrom
Andreea2194:main

Conversation

@Andreea2194

Copy link
Copy Markdown

No description provided.

Comment thread package.json
"scripts": {
"start": "parcel",
"build": "parcel build",
"push-gh-pages": "push-dir --dir=dist --branch=gh-pages --cleanup --verbose"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dacă nu publici pe GH Pages, poți să renunți la scriptul acesta, și la dependința de push-dir

Comment thread package.json
"push-dir": "^0.4.1"
},
"dependencies": {
"bootstrap": "^5.2.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dacă nu folosești Bootstrap, nu e nevoie să îl ai ca dependință.

Comment thread src/boutique.html
<img src="./img/404-tick.png">
<br />
<br />
<h7>Thank you!</h7>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nu există <h7>.

Comment thread src/boutique.scss
margin-block-start: 0rem;
margin-inline: 3rem;
text-align: center;
margin-block-start: 1rem;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aliniază frumos liniile de mai sus

Comment thread src/boutique.scss
border: 0;
outline: none;
border-radius: 4px;
cursor: pointer;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aliniază frumos cele 3 linii.

Comment thread src/boutique.scss
.popup h7, .popup1 h7 {
font-size: 50px;
}
.popup button, .popup1 button {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dacă tot ai numit fișierul .scss, ai putea să profiți de Sass.

De exemplu, ai putea simplifica aceești selectori:

.popup, .popup1 {
    img {
        // ....
    }

    button {
        // ....
    }
}

Comment thread src/csr.html
<img class="photo3" src="./img/pexels-cottonbro-3831881 (1).jpg">
<h2 class="title3">Made for super you</h2>
<p class="p3">Speed. Ease. Looking good while getting things done. We’re all about making a statement—with our makeup, voice and
style—and want you to feel confident in your skin.</p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aliniază frumos tot acest fișier.

Comment thread src/csr.scss
margin: 0;
padding: 0;
font-family: "Inter", sans-serif;
background-image: url(./img/photo-1578662996442-48f60103fc96.jpeg);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ți-aș recomanda să schimbi numele tuturor fișierelor de imagini, pentru a fi mai evident ce reprezintă fiecare.

Comment thread src/csr.scss
.cssphoto3 {
grid-area: 3/1/6/3;
width:50vw;
height: 40vh;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aliniază frumos tot fișierul acesta.

Comment thread src/index.html
<div class="row2">
<hr>
<p class="copyright-text">Copyright &copy; 2022 All Rights Reserved by
<a href="#">The Lippie Factory</a>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cred că ai uitat </p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants