Migrate to ruff for linting and formatting#11
Merged
IbraheemTuffaha merged 6 commits intoIbraheemTuffaha:mainfrom Mar 6, 2025
Merged
Migrate to ruff for linting and formatting#11IbraheemTuffaha merged 6 commits intoIbraheemTuffaha:mainfrom
IbraheemTuffaha merged 6 commits intoIbraheemTuffaha:mainfrom
Conversation
Owner
|
I love it! |
avoig conflict between hook and local
Contributor
Author
|
Updated the action and pushed a fixup commit ( can be auto squashed on merged) |
Owner
|
So |
|
IbraheemTuffaha
approved these changes
Mar 6, 2025
Owner
IbraheemTuffaha
left a comment
IbraheemTuffaha
left a comment
There was a problem hiding this comment.
I added a few changes, if they look good to you, then we can merge
Contributor
Author
|
Yes looks great, sorry I did not check the whole code base and missed up some changes |
Owner
|
Thanks a lot for your contribution ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing a big speed boost from switching to uv, I wanted to try Ruff, a Rust-based formatter and linter. It’s super fast and can replace Black, Flake8, and isort all in one.
In this PR:
Added Ruff for formatting and linting
Kept it compatible with the previous setup
Removed Black, Flake8, and isort since Ruff handles everything
Let me know what you think!