Repository navigation
knowledge: remove the CannBot stage-evidence distillation from #114 - #489
jiangkuaixue123 wants to merge 2 commits into
Conversation
…ixLab#114 Signed-off-by: jiangkuaixue123 <jiangxiaozhou111@163.com>
Signed-off-by: jiangkuaixue123 <jiangxiaozhou111@163.com>
Skill evaluationPLANNED: not executed; there are no task outcomes yet.
Author verification steps (nonpaid; not yet run)
python tools/build_skill_index.py --source-revision 4eef72ee00e8d1f7792c79d79519da60705608bd --checkThe declared source pin matches this head's canonical library bytes. The command has not run: retain its exit code and full drift/success output. It checks the generated projection, not claim truth or skill efficacy. Evidence and logs · Retention: 30 days. Plan bindings, budget, frozen exam and advisory detailsAdvisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Model/settings:
Automatic execution / cumulative PR budget: {"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}Projection check selection (not an executed result): {"declared_in":"src/inferrsi/knowledge/data/repo_packs/inferrsi/knowledge/_provenance.json","source_revision":"4eef72ee00e8d1f7792c79d79519da60705608bd","status":"ready"}Provider/settings: Uncovered / unsupported paths (12)
|
zengchuang-hw
left a comment
There was a problem hiding this comment.
PR review verdict — DO NOT PASS
Independent first review of base 8aba657da79e8ed9f6e6fbb33437e9d9fdd8f1c7 → head 91a40ba22dbf0c67209d0ec2ec6354e45b184f7f (12 changed files). Previous review: none; resolved prior findings: not applicable.
Reviewer: dot, acting under zengchuang-hw's standing delegation to independently review other contributors' PRs and publish findings. This is a COMMENT, not REQUEST_CHANGES; I am not approving or merging this revision.
Required before approval
- Update the installed-resource acceptance test for the intentional deletions.
tests/check_installed.py:544still asserts 930 resources, but this PR removes two packaged reference files. Independently enumerating the exact head's Git tree gives 928 files under the Knowledge/Harness data roots. The Python 3.11 installed-package job fails at that assertion with “installed resource count is 928, expected 930”; Python 3.10 is also failed. Adjust the intended inventory expectation while retaining the complete checkout/wheel byte comparison and registered-resource checks, and rerun both installed-package lanes. Do not restore the unwanted references merely to satisfy the old count. - Resolve the current-head knowledge declaration failure truthfully. The PR declares material author model/effort as
unknown. The declarations job evaluated this exact head and reportsMaterial AI author 1: model is unapproved or suspended. Provide verifiable actual author/model/effort provenance meeting the repository policy, or route the unresolved provenance to its policy owner; do not replace unknown values by guesses.
Independent scope checks
- Reviewed the removal from the skill procedure, sidecar, generated abstract, source inventory, README and both coverage matrices. The removed direct CannBot readset/license and review-case file correspond to the stated #114 distillation slice; the diff does not edit the external lookup adapter or historical campaign evidence.
- Fetched the pre-#114 skill at
61cdfebfd871fcb007d289d4d1f10c55e65813cdunder its oldsrc/inferrsi/data/path and compared its complete text with the current skill: identical. The existing MindIE-SD five-layer analysis and shared-machine measurement procedure are preserved. - Read AGENTS.md, the repository review skill, contribution/collaboration rules and linked #91/#476 scope context. The proposed external-query work and this removal do not establish licensing approval or close the broader governance tasks.
- Checked all 12 file statuses and the complete recursive tree (not truncated), current head/base, own-review history and GitHub check metadata. No other reviewers' opinions were used.
Verification limits
I performed connector-based static inspection and read the actual CI failure logs; I did not run pytest, Ruff, index/coverage regeneration, wheel installation or hardware experiments locally. Author-reported local tests are not independent reruns. At the latest check, full-check 3.10/3.11 and Windows compatibility were still running, macOS was queued, and browser/skill-eval execution were skipped; plan, publish and PR references passed. Therefore this is not an all-green or complete runtime-validation claim.
Non-blocking suggestion: add a focused regression asserting the two retired references are absent while the preserved skill remains readable, alongside the corrected full inventory test.
zengchuang-hw
left a comment
There was a problem hiding this comment.
PR review verdict — DO NOT PASS
Evidence-driven incremental review of unchanged head 91a40ba22dbf0c67209d0ec2ec6354e45b184f7f (base 8aba657da79e8ed9f6e6fbb33437e9d9fdd8f1c7), following my initial review. No new commits; this update records a newly completed full-check failure, not a duplicate review of unchanged evidence.
Additional required correction: src/inferrsi/knowledge/data/skill_library/hardware/ascend/ascend-performance-analysis/metadata.json:16 replaces the removed source with "sources": []. The existing contract in tests/test_knowledge_contract.py:37–48 deliberately requires omission of empty reader-default fields. Full-check Python 3.11 now confirms this exact assertion fails for ascend-performance-analysis (1 failed, 5075 passed, 36 skipped, 671 subtests passed). Remove the empty sources field rather than weakening the contract, then regenerate the generated index/provenance and coverage as required and rerun the relevant/full checks. Preserve the remaining MindIE-SD attribution in the procedure/inventory; do not invent a normalized source record merely to silence the test.
The installed-resource-count and declaration blockers from the prior review remain unresolved. Windows compatibility also fails on the same 928 versus 930 installed-resource assertion, independently confirmed in its raw job log. No prior blocker is closed by this update.
Actual verification: independently read the sidecar and contract test at this exact head and the newly finished raw CI logs, then rechecked current head and own posted review. No other review opinions used; no local tests or repository code execution, no branch edit, approval or merge. Reviewer remains dot acting for zengchuang-hw under the standing review/publication delegation. No additional non-blocking suggestion.
Refs #91 and #476. Follow-up to #484.
The maintainer requested removal of the direct CannBot distillation introduced by #114. This removes its stage-report procedure, readset, accompanying license copy, review cases, and current coverage entries. The Ascend profiling procedure matches its pre-#114 version. The older mirrored skills, external lookup adapter, and historical campaign snapshots are preserved.
The packaged skill index and coverage checks succeeded. The skill catalog, index, and coverage tests passed locally.