feat: raise the WinRM post-sync command limit to 8192 characters - #358
Open
bernie-g wants to merge 3 commits into
Open
feat: raise the WinRM post-sync command limit to 8192 characters#358bernie-g wants to merge 3 commits into
bernie-g wants to merge 3 commits into
Conversation
Send the script to the host over stdin rather than on the PowerShell command line. cmd.exe rejects a command line past ~8155 characters (measured against a live Server 2016 host) and -EncodedCommand inflates a script ~3.2x on the way there, so the usable ceiling was ~2555. A fixed bootstrap now takes the command line and reads the real script from stdin. The script crosses base64-encoded, so the host's console code page cannot alter it: the ASCII-only restriction is gone, and the pkcs12 password no longer appears in the host's process table. Serialize SOAP requests per client. NTLM message sealing is RC4 keyed by a sequence counter, and the library issues the stdin Send concurrently with the output Receive without locking, desynchronizing the keystream and failing with "checksum does not match". Commands that write stdin also use a shorter WSMan operation timeout so the output poll releases the lock promptly instead of long-polling for 60s. Also shortens noOutcomeMessage to fit the control plane's 120-character failure-detail cap, which previously cut it mid-quote and dropped the part telling the operator what to do instead.
|
💬 Discussion in Slack: #pr-review-cli-358-feat-raise-the-winrm-post-sync-command-limit-to-8192-character Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
11 tasks
Contributor
|
| Filename | Overview |
|---|---|
| packages/gateway-v2/winrm/winrm.go | Implements stdin-based script delivery and serialized SOAP transport, but applies the polling timeout to setup and input operations as well. |
| packages/gateway-v2/winrm_handler.go | Raises the product limit to 8192 characters while retaining byte-based validation that rejects valid non-ASCII commands. |
| packages/gateway-v2/winrm/winrm_command_test.go | Adds useful encoding and limit coverage, but command-limit tests exercise only single-byte ASCII input. |
| packages/gateway-v2/winrm/winrm_transport_test.go | Verifies transport serialization and timeout configuration but not the effect of that timeout on non-polling operations. |
Reviews (1): Last reviewed commit: "feat: raise the WinRM post-sync command ..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The gateway measured the command with len(), a byte count, while the
control plane's limit counts characters. Now that a command may be
non-ASCII, 8192 accented characters is 16384 bytes, so the gateway
rejected a command the UI had already accepted, after the certificates
were delivered.
Also raises the gateway cap and reframes it as a backstop rather than a
second copy of the product limit. The command arrives with placeholders
substituted, and {{certificateFiles}} grows with the number of
certificates delivered, so it needs headroom over what an operator can
save.
The short timeout applied to every operation on the client, not just the output poll it was meant for. Shell creation, Command, Send, Signal and Delete inherited a two-second budget, and none of them retries on a w:TimedOut fault, so a host that was merely slow failed the sync outright. It existed only to break a standoff: the output poll held the transport lock waiting for output, and no output could arrive until stdin was written, which needed the same lock. The bootstrap now writes one byte before it blocks on stdin, so the poll returns as soon as PowerShell starts and releases the lock on its own. The timeout override is gone and newClient is untouched again. The sentinel is stripped with TrimPrefix, which removes a single occurrence, so a command that itself opens by printing that byte keeps it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
Sends the post-sync PowerShell script to the Windows host over stdin instead of on the command line, lifting the effective ~2555-character ceiling imposed by cmd.exe to the new 8192 product limit and removing the reason a command had to be ASCII.
Paired with Infisical/infisical#7620, which raises the matching schema cap. PKI-348.
Type ✨
Tests 🛠️
go build ./... go vet ./packages/gateway-v2/winrm/ go test -race ./packages/gateway-v2/...Unit coverage added for the UTF-16LE encoding (including surrogate pairs), the base64 payload round trip, and the transport serialization. The serialization test is paired with a control test asserting the same probe does observe overlap when unwrapped, so it cannot pass vacuously.
Live-host validation is still outstanding. The mechanism was developed against a Windows Server 2016 / PowerShell 5.1 host, but the NTLM serialization fix has not yet been exercised end to end by a real sync.