fix: multi-connection proxy pam - #362
Conversation
|
💬 Discussion in Slack: #pr-review-cli-362-fix-multi-connection-proxy-pam Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
|
| Filename | Overview |
|---|---|
| packages/pam/local/base-proxy.go | Separates shutdown signaling from cleanup and introduces a proxy-wide establishment-failure counter whose threshold can terminate a still-usable multi-connection session. |
| packages/pam/local/database-proxy.go | Keeps the listener alive after individual stream closure but contributes each independently failed connection to the shared session-loss threshold. |
| packages/pam/local/kubernetes-proxy.go | Adopts common per-connection close handling and shared establishment-failure tracking for kubectl connections. |
| packages/pam/local/rdp-proxy.go | Preserves reconnect behavior after stream closure while adding relay and gateway failures to the shared shutdown threshold. |
| packages/pam/local/redis-proxy.go | Stops treating a stream close as session loss but can still terminate the session after three independent establishment failures. |
| packages/pam/local/ssh-proxy.go | Moves SSH stream closure to per-connection handling and participates in the proxy-wide failure threshold. |
| packages/pam/local/azure-proxy.go | Uses idempotent shutdown signaling and invokes cleanup when that signal is observed; no changed-code defect was identified. |
| packages/pam/local/gcp-proxy.go | Routes the shutdown signal through graceful cleanup; its existing cloud-proxy connection behavior is otherwise unchanged. |
Reviews (1): Last reviewed commit: "fix: multi-connection proxy pam" | Re-trigger Greptile
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 1 · PR risk: 0/10 |
759068b to
86d3b62
Compare
Description 📣
This PR ensures that local proxy process is still UP even when a client connection cancels
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets