fix: exclude demo .vue files from library type-check so fresh builds … - #305
Merged
Merged
Conversation
…pass vue-tsc in packages/hooks type-checked src/**/demo/*.vue, but several useRequest plugin demos import @vue-hooks-plus/use-request-plugins, whose published types only exist after that sibling package is built. Since addon packages depend on vue-hooks-plus, hooks always builds first in 'pnpm recursive exec', so a fresh checkout (and CI) could never build: vue-tsc failed on those demos with 7 type errors. Demos are documentation material compiled by vitepress's own pipeline and are not part of the published artifacts, so the library build should not gate on them. Verified: 'pnpm build' now succeeds from a fully clean state (no dist/es/lib anywhere); 319/319 tests and the 80% coverage gate still pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pass
vue-tsc in packages/hooks type-checked src/**/demo/*.vue, but several useRequest plugin demos import @vue-hooks-plus/use-request-plugins, whose published types only exist after that sibling package is built. Since addon packages depend on vue-hooks-plus, hooks always builds first in 'pnpm recursive exec', so a fresh checkout (and CI) could never build: vue-tsc failed on those demos with 7 type errors.
Demos are documentation material compiled by vitepress's own pipeline and are not part of the published artifacts, so the library build should not gate on them. Verified: 'pnpm build' now succeeds from a fully clean state (no dist/es/lib anywhere); 319/319 tests and the 80% coverage gate still pass.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge