Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

PR #300 proposed removing the redundant Microsoft.CodeAnalysis.Workspaces.Common dependency, which is already a transitive dependency of Microsoft.CodeAnalysis.Workspaces.MSBuild. The changes remain valid for the current codebase.

Changes

  • Removed redundant dependency: Microsoft.CodeAnalysis.Workspaces.Common from Directory.Packages.props

    • Already pulled in transitively by Microsoft.CodeAnalysis.Workspaces.MSBuild
  • Added Directory.Packages.props to solution items for easier Visual Studio access

Original prompt

Take a look at https://github.com/IntelliTect/CodingGuidelines/pull/300/changes and if it is still true and valid and if it is, make changes for our codebase as it is today.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…and add Directory.Packages.props to solution items

Co-authored-by: BenjaminMichaelis <[email protected]>
@BenjaminMichaelis BenjaminMichaelis marked this pull request as ready for review February 3, 2026 22:20
Copilot AI review requested due to automatic review settings February 3, 2026 22:20
Copilot AI changed the title [WIP] Update coding guidelines for current codebase Apply PR #300: Remove redundant Workspaces.Common dependency Feb 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies changes from PR #300 to clean up package dependencies by removing a redundant direct reference to Microsoft.CodeAnalysis.Workspaces.Common, which is already included as a transitive dependency of Microsoft.CodeAnalysis.Workspaces.MSBuild. Additionally, it improves project organization by adding Directory.Packages.props to the solution's visible items.

Changes:

  • Removed redundant Microsoft.CodeAnalysis.Workspaces.Common package reference from central package management
  • Added Directory.Packages.props to Solution Items for better visibility in Visual Studio

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Directory.Packages.props Removes the redundant Microsoft.CodeAnalysis.Workspaces.Common package version entry since it's a transitive dependency
IntelliTect.Analyzer.sln Adds Directory.Packages.props to Solution Items for improved visibility and accessibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BenjaminMichaelis BenjaminMichaelis merged commit 12bd282 into main Feb 3, 2026
2 checks passed
@BenjaminMichaelis BenjaminMichaelis deleted the copilot/update-coding-guidelines branch February 3, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants