Enforce 7-day cooldown for npm packages too#3
Open
interworks-morr wants to merge 1 commit into
Open
Conversation
config:best-practices bundles security:minimumReleaseAgeNpm, which sets minimumReleaseAge to 3 days for npm via a packageRule. Because packageRules override top-level config, that 3-day rule was silently overriding the intended top-level minimumReleaseAge of 7 days for every npm dependency (e.g. prettier PRs were raised at 3 days old). Add a trailing npm packageRule restoring the 7-day cooldown for npm too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The top-level
minimumReleaseAge: "7 days"in this preset is not being applied to npm packages. It's silently overridden down to 3 days for everything from npm.Why: this preset extends
config:best-practices, which bundlessecurity:minimumReleaseAgeNpm— "Wait until the npm package is three days old before raising the update." That's a packageRule (matchDatasources: ["npm"]→minimumReleaseAge: "3 days"), and packageRules override top-level config for matching packages. So:7 days→ effectively applies only to non-npm datasources.This surfaced in
internal-deployment: prettier3.8.4(published 2026-06-09) had a PR raised at 3 days old (2026-06-12), with Renovate's stability check reporting "met minimum release age requirement" — because the effective npm cooldown was 3 days, not 7.Fix
Append an npm packageRule (after
config:best-practices, so it wins) restoring the 7-day cooldown for npm:{ "matchDatasources": ["npm"], "minimumReleaseAge": "7 days" }After this, npm dependencies wait the full 7 days, matching the intent of the top-level setting. Non-npm datasources are unaffected (still 7 days via top-level).
Verification
Once merged, the next Renovate run on consuming repos should hold npm updates younger than 7 days (visible as "Pending Status Checks" on their dependency dashboards) rather than raising PRs at 3 days.
🤖 Generated with Claude Code