perf(teamrec): avoid calling ListMembers inside loop#70
Merged
Conversation
Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
tstollin
approved these changes
Jul 17, 2026
tstollin
left a comment
tstollin
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Nice find! Thanks :)
But I need to look into the fact that not all required workflows ran after approving their execution. I'm on it.
Contributor
Fix incoming: #73 EDIT: fixed |
tstollin
reviewed
Jul 17, 2026
KRaffael
approved these changes
Jul 17, 2026
Contributor
|
🎉 This PR is included in version 0.5.1 🎉 The release is available on GitHub release and as container image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the Team reconciler by calling
ListMembersonly once. This will also consume less of the API rate-limit budget.Type of Change
Checklist
Related Issues