-
Notifications
You must be signed in to change notification settings - Fork 94
ChainSync Timeouts #5256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ChainSync Timeouts #5256
Conversation
cardano-diffusion/framework/lib/Cardano/Network/Driver/Limits.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/tests/lib/Test/Cardano/Network/Diffusion/Testnet/MiniProtocols.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/framework/lib/Cardano/Network/Driver/Limits.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/framework/lib/Cardano/Network/Driver/Limits.hs
Outdated
Show resolved
Hide resolved
cardano-diffusion/protocols/lib/Cardano/Network/Protocol/ChainSync/Codec/TimeLimits.hs
Show resolved
Hide resolved
cardano-diffusion/protocols/lib/Cardano/Network/Protocol/ChainSync/Codec/TimeLimits.hs
Show resolved
Hide resolved
920f7fa to
6f493ea
Compare
docs/network-spec/miniprotocols.tex
Outdated
| The table~\ref{table:chain-sync-timeouts} specifies message timeouts in a given | ||
| state. If a timeout is violated, the connection SHOULD be torn down. | ||
|
|
||
| The timeout on state \StMustReply{} only applies if the peer is not trustable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coot Should we include this in the spec, or add more details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expanding this section is a good idea.
cardano-diffusion/protocols/lib/Cardano/Network/Protocol/ChainSync/Codec/TimeLimits.hs
Show resolved
Hide resolved
| timeLimitForStateWithRnd limits (SingNext SingMustReply) (mkStdGen seed) | ||
|
|
||
|
|
||
| -- TODO Duplicated code: move ouroboros-network-tests-lib OrphanInstances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can wait until #5241 got merged.
|
If you rebase on master, the dmq-node related patches should be removed as it is no longer part of this repo. |
Co-authored-by: coot <[email protected]>
a475086 to
3dc3399
Compare
Description
Closes #5250.
Checklist
Quality
Maintenance
ouroboros-networkproject.