Skip to content

Conversation

@the-headless-ghost
Copy link
Member

@the-headless-ghost the-headless-ghost commented Dec 4, 2025

Description

Closes #5250.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@the-headless-ghost the-headless-ghost force-pushed the edgr/chainsync-timeouts branch 2 times, most recently from 920f7fa to 6f493ea Compare December 11, 2025 05:24
The table~\ref{table:chain-sync-timeouts} specifies message timeouts in a given
state. If a timeout is violated, the connection SHOULD be torn down.

The timeout on state \StMustReply{} only applies if the peer is not trustable.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coot Should we include this in the spec, or add more details?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanding this section is a good idea.

timeLimitForStateWithRnd limits (SingNext SingMustReply) (mkStdGen seed)


-- TODO Duplicated code: move ouroboros-network-tests-lib OrphanInstances
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can wait until #5241 got merged.

@the-headless-ghost the-headless-ghost marked this pull request as ready for review December 18, 2025 07:29
@the-headless-ghost the-headless-ghost requested a review from a team as a code owner December 18, 2025 07:29
@crocodile-dentist
Copy link
Contributor

If you rebase on master, the dmq-node related patches should be removed as it is no longer part of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

ChainSync Timeouts

4 participants