Direct tests for ObjectDiffusion mini protocol #5267
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustinmista
changed the title
agustinmista
force-pushed
the
peras-diffusion-direct-tests
branch
from
0e60a22 to
00954ec
Compare
7 tasks
agustinmista
commented
Dec 12, 2025
Comment on lines
+185
to
+192
| (SingBlocking, []) -> | ||
| -- NOTE: the current version of this protocol doesn't have a | ||
| -- way to inform the inbound side that it's caught up. This | ||
| -- means that there's no propert inhabitant for this type. | ||
| -- | ||
| -- This will be solved by: | ||
| -- https://github.com/tweag/cardano-peras/issues/144 | ||
| error "We can't return anything meaningful here, so let's crash" |
Contributor
Author
There was a problem hiding this comment.
This needs to be fixed.
|
Blocked on tweag/cardano-peras#187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements direct-style tests for ObjectDiffusion, inspired by the corresponding implementation from TxSubmission2.
NOTE: this is currently failing because the protocol doesn't have a way to inform the outbound side that it's caught up, so
recvMsgRequestObjectIdscan't be defined in a terminating way.This will be addressed by: tweag/cardano-peras#144
Checklist
Quality
Maintenance
ouroboros-networkproject.