Costing for improved integer/bytestring conversions #7491
+402
−355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the cost model to reflect the improved performance of
integerToByteStringandbyteStringToIntegerdue to #7439: the execution times of both functions are now linear in the sizes of their inputs instead of quadratic: see thebuiltinCostModelJSON files.For small inputs values (less than size 2 or 3, so about 20 bytes) the new costs are slightly higher than the old ones (possibly due to randomness in the benchmarking process), but for larger inputs the new versions are dramatically faster: see the attached PNGs (blue points are benchmark times for the old versions, green ones are for the new versions).
The costing functions in this PR are provisional and may be updated before the new cost model is deployed on the chain.