[PERFORMANCE] Fix Memory Leaks caused by EditorVariableWaveform + Optimize it#262
Open
menvae wants to merge 3 commits into
Open
[PERFORMANCE] Fix Memory Leaks caused by EditorVariableWaveform + Optimize it#262menvae wants to merge 3 commits into
EditorVariableWaveform + Optimize it#262menvae wants to merge 3 commits into
Conversation
+ optimize EditorVariableWaveform + add notify closing for points
EditorVariableWaveform + Optimize itEditorVariableWaveform + Optimize it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
EditorVariableWaveformis now aBufffedContainerand we use.CreateViewto draw it.OnDisposeis internal and we don't untrack on all cases of dispose as is the case ofPointListEntryOnClosevirtual method inPointListEntryto know when point is closed. This is needed for untracking the point for the waveform when closing.We track the drawables to know if it is
IsPresentso we know to not render the waveform if any of the consumers aren't even rendered themselves.FIxes #247