Skip redundant line-number comments on empty lines#237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-- 123) forEmptyLine_tnodes insidetablelit,tableblockandclassblockwhenreserve_line_number/-lwas enabled, producing redundant comment-only lines in generated output.Description
nl(ast_node* node)insrc/yuescript/yue_compiler.cppto return only the newline forEmptyLine_tnodes when_config.reserveLineNumberis true, avoiding the-- <line>suffix for blank lines.spec/cli/test_compilation.shthat compiles a file containing empty lines inside table/class blocks and asserts no standalone-- <number>lines are present.src/yuescript/yue_compiler.cppandspec/cli/test_compilation.sh.Testing
make -j4and the build completed successfully.YUE_BIN=./yue spec/cli/test_compilation.shand all tests passed (21/21), including the new regression asserting empty lines do not produce standalone line-number comment lines.Codex Task