Replace setup.py for pyproject.toml#400
Open
arjanz wants to merge 2 commits into
Open
Conversation
yabirgb
reviewed
Jul 17, 2024
Comment on lines
+44
to
+49
| if os.getenv('GITHUB_REF'): | ||
| if not os.getenv('GITHUB_REF').startswith('refs/tags/v'): | ||
| raise ValueError('Incorrect tag format {}'.format(os.getenv('GITHUB_REF'))) | ||
| __version__ = os.getenv('GITHUB_REF').replace('refs/tags/v', '') | ||
| else: | ||
| __version__ = '0.0.0-dev1' |
Contributor
There was a problem hiding this comment.
not sure if it is useful for you but we use https://pypi.org/project/setuptools-scm/ with a fallback version that we bump with a script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
setup.pyis not fully deprecated yet, the community is moving towardspyproject.tomlfor future-proofing and better integration with new tools and standards.See #399