Repository navigation
Wire both hubs through Svc.ComQueue + Svc.ComStub and report the hub allocation counter - #5
Open
devin-ai-integration[bot] wants to merge 6 commits into
Open
devin-ai-integration[bot] wants to merge 6 commits into
devin-ai-integration[bot] wants to merge 6 commits into
Conversation
…omStub, split the driver receive pool, report the hub counter; integration test for queue telemetry Follows the recommended hub wiring from Svc/GenericHub/docs/sdd.md (JPL-Devin/fprime#278): hub.toBufferDriver -> ComQueue.bufferQueueIn[0] -> ComStub -> Drv.Udp, queue depth 30 (= hub pool), instance queue 40 (= pool + 8). The byte-stream adapter stays on the receive side. Each hub gets schedIn from rate group 3 so NumAllocationFailures is reported. ComponentA uses the new Svc::GenericHub_HubType FPP enum. lib/fprime points at the #278 branch head.
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
Original prompt from thomas.boyer.chammard
|
…l size held once in FPP (local review iter 4)
…elper; lib/fprime -> 82f06a583a (local review iter 4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to JPL-Devin/fprime#278 (nasa/fprime#6166). Both deployments now use the recommended hub wiring from the GenericHub SDD "Transport formations" section:
*_hubComQueue(depth 30 = hub pool size, instance queue 40 = pool + 8),*_hubComStub, and*_hubComDriverBufferManagerso the driver's receive pool no longer competes with the hub's send pool. Receive path unchanged (Drv.Udp -> ByteStreamBufferAdapter -> hub).rateGroup3 -> hub.schedInsoNumAllocationFailuresis reported;rateGroup1 -> hubComQueue.runfor queue telemetry.ComponentAuses the newSvc::GenericHub_HubTypeFPP enum (HUB_TYPE_MAX→NUM_CONSTANTS).test_hub_no_allocation_failures,test_hub_queue_telemetry(depth channel received, counter 0, noBufferAllocationFailed/QueueOverflow). Suite: 8/8 against both deployments on this wiring.lib/fprimepoints at the #278 branch head on the JPL-Devin fork; re-point to the upstream commit once #278 merges (the submodule URL is nasa/fprime, so CI here cannot resolve it until then).Requested by: @thomas-bc-autobot