Skip to content

chore: refuse release.sh from main; require release branch #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jamkris merged 1 commit into from
May 12, 2026
Merged

chore: refuse release.sh from main; require release branch #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,25 @@ fi
# Remove 'v' prefix if provided
VERSION="${VERSION#v}"

# Refuse to run on main. The release workflow expects the version
# bump to land via a reviewable PR — committing directly to main
# bypasses CI, code review, and the merge audit trail. If you really
# need to release from main (genuine emergency), comment out this
# guard temporarily; do not add an env-var escape hatch because that
# normalises the wrong path.
BRANCH=$(git rev-parse --abbrev-ref HEAD)
if [ "$BRANCH" = "main" ]; then
echo "Error: refusing to run release from 'main' branch." >&2
echo "" >&2
echo "Version bumps must go through a PR:" >&2
echo " 1. git checkout -b chore/release-v$VERSION" >&2
echo " 2. ./scripts/release.sh $VERSION # re-run on the release branch" >&2
echo " 3. git push -u origin chore/release-v$VERSION" >&2
echo " 4. gh pr create --title \"chore: release v$VERSION\" --body \"Bump version to $VERSION\"" >&2
echo " 5. Merge once CI is green, then push the tag." >&2
exit 1
fi

echo "Preparing release v$VERSION..."

# 1. Update package.json
Expand All @@ -42,17 +61,9 @@ git commit -m "chore: bump version to $VERSION"
echo "Creating tag v$VERSION..."
git tag "v$VERSION"

BRANCH=$(git rev-parse --abbrev-ref HEAD)

echo "Done!"
echo "Next steps:"
echo "1. git push origin $BRANCH"
echo "2. git push origin v$VERSION"
if [ "$BRANCH" != "main" ]; then
echo "3. Create a PR to merge '$BRANCH' into main"
echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
echo "4. After merge, push the tag: git push origin v$VERSION"
echo "5. Check GitHub Actions for the Release process."
else
echo "3. Check GitHub Actions for the Release process."
fi
echo "1. git push -u origin $BRANCH"
echo "2. gh pr create --title \"chore: release v$VERSION\" --body \"Bump version to $VERSION\""
echo "3. After merge, push the tag: git push origin v$VERSION"
echo "4. Check GitHub Actions for the Release process."
Loading