Remove LockSupport implementation details from the trace#662
Open
Evgeniy Moiseenko (eupp) wants to merge 12 commits into
Open
Remove LockSupport implementation details from the trace#662Evgeniy Moiseenko (eupp) wants to merge 12 commits into
LockSupport implementation details from the trace#662Evgeniy Moiseenko (eupp) wants to merge 12 commits into
Conversation
…kingTrackerTransformer`. Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
…t supported in mc yet) Signed-off-by: Evgeniy Moiseenko <evg.moiseenko94@gmail.com>
Evgeniy Moiseenko (eupp)
force-pushed
the
eupp/park-trace-fix
branch
from
cd61cb5 to
11b54d6
Compare
| | status ➜ 3 at AbstractQueuedSynchronizer$ConditionNode.isReleasable(AbstractQueuedSynchronizer.java:515) | | ||
| | LockSupport.park() at AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:519) | | ||
| | PARK at LockSupport.park(LockSupport.java:371) | | ||
| | PARK at AbstractQueuedSynchronizer$ConditionNode.block(AbstractQueuedSynchronizer.java:519) | |
Collaborator
There was a problem hiding this comment.
Wouldn't it be more intuitive to leave LockSupport.park() and hide PARK?
Collaborator
Author
There was a problem hiding this comment.
Yes, I agree.
But I suggest doing it in a separate PR, because:
- we will need to change bytecode transformer and trace point logic;
- for consistency, we also need to do this for other APIs, i.e., print
Object.wait()instead ofWAIT.
| /** | ||
| * [ParkingTransformer] tracks [Unsafe.park] and [Unsafe.unpark] method calls, | ||
| * injecting invocations of [EventTracker.park] and [EventTracker.unpark] methods. | ||
| * The ParkingTransformer class is responsible for inserting bytecode instrumentation |
Collaborator
There was a problem hiding this comment.
Is it just a refactoring here?
Collaborator
There was a problem hiding this comment.
If the hiding logic is here, please consider doing it on the trace post-processing phase
Collaborator
Author
There was a problem hiding this comment.
Is it just a refactoring here?
I changed the transformer to track both Unsafe and LockSupport part APIs.
Besides improving trace, tracking LockSupport directly also simplifies another thing in ManagedStrategy.kt (see the diff).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #627