Skip to content

#34 Battle details: own team's group first - #122

Merged
JimGeersinga merged 1 commit into
issue/32-virtualize-whole-tablefrom
issue/34-own-team-first
Nov 16, 2026
Merged

JimGeersinga merged 1 commit into
issue/32-virtualize-whole-tablefrom
issue/34-own-team-first

Conversation

@JimGeersinga

@JimGeersinga JimGeersinga commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Closes #34

Stacked on #121 (#32): the base is issue/32-virtualize-whole-table. Merge #121 first; this PR then retargets to master.

In the battle details your own team's group comes first and starts open, whatever the column sort does. MudTable orders its groups by each group's first row in the sorted list, so every SortBy in Details.razor now goes through By(...). It puts the own team's rows first in either direction (a Ranked key: the rank first, then the column's own value), so the order inside a group is unchanged. With no own team every rank is 0 and the order stays Team 1, Team 2. Version 3.17.0.0 (raised after master went to 3.16.0.0 with #120) (story → minor). ui-only: no review round.

Acceptance (checked over CDP on the signed-in Debug build, default XP-descending sort)

  • Own team first and open, other team collapsed below it: this held in all 21 battles opened. In 15 of them the other team held the top XP, e.g. battle 0 below (own top 177, MESTA 927).
  • Own team first under every column sort: all 11 sort labels, each clicked ascending, descending and back. Own group stayed first and open every time.
  • No own team keeps Team 1, Team 2: true by construction only (every rank 0); none of the battles opened lacked an own team.
  • Not separately confirmed: that one of the checked battles has the own team as Team 2. The team number isn't in the DOM, but the own team was first in every case regardless.
  • Build: dotnet build … -f net11.0-windows10.0.19041.0, 0 errors, 0 warnings.

Screenshots

Own team first, 1280×800
Own team first, 1920×1080

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@JimGeersinga
JimGeersinga added this pull request to stack #123 November 15, 2026 23:58
@JimGeersinga
JimGeersinga merged commit 154587e into master Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Battle details: own team's group first

1 participant