Report element count in generator-too-short error - #1348
Open
JohnCobbler wants to merge 1 commit into
Open
Conversation
The error printed the failing CartesianIndex coordinate instead of the number of elements produced, so a one-short generator of length 5 reported "stopped at 5" even though only 4 values were produced. Report LinearIndices(inds)[i]-1 as the count. Remove unused shape_string(::CartesianIndex). Tests use occursin for Julia 1.6 compat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The too-short generator error printed the failing
CartesianIndexcoordinate via
shape_string(i), not the number of values actuallyproduced. For
SVector{5}(i for i in 1:5 if i != 2)that showed"stopped at 5" even though only 4 elements were yielded.
Report the produced count as
LinearIndices(inds)[i] - 1instead, anddrop the unused
shape_string(::CartesianIndex)method.Fixes #1207