Remove the in-place rewrite mode - #306
Merged
Merged
Conversation
The declarative `inplace=true` mode mutates matched producer operations. Its `find_matched_ssa` helper does not preserve pattern identity: it selects the first same-function user of a binding. A decoy operation can therefore be mutated even when the use-count guard proposed in #304 succeeds. Remove the mode and express its sole comparison rule as a normal rewrite. The standard path builds a new interior addi and only replaces the matched cmpi root, leaving shared producers unchanged. Teach RHS type inference to consider SSA values, block arguments, and kernel arguments, promoting scalar arguments to 0-D tiles. Add regressions for shared and decoy addi chains and for argument-only interior-operation typing. Co-authored-by: Simeon David Schaub <simeon.schaub@enpc.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declarative
inplace=truemode mutates matched producer operations. Itsfind_matched_ssahelper does not preserve pattern identity: it selects the first same-function user of a binding. A decoy operation can therefore be mutated even when the use-count guard proposed in #304 succeeds.Remove the mode and express its sole comparison rule as a normal rewrite. The standard path builds a new interior addi and only replaces the matched cmpi root, leaving shared producers unchanged.
Teach RHS type inference to consider SSA values, block arguments, and kernel arguments, promoting scalar arguments to 0-D tiles. Add regressions for shared and decoy addi chains and for argument-only interior-operation typing.
Closes #304