Skip to content

Conversation

@termi-official
Copy link
Collaborator

@termi-official termi-official commented Sep 4, 2024

Closes #189

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 68.75369% with 529 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.71%. Comparing base (009811a) to head (f427a8f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ferrite-addons/PR883.jl 0.00% 41 Missing ⚠️
src/utils.jl 41.37% 34 Missing ⚠️
src/modeling/solid/contraction.jl 57.69% 33 Missing ⚠️
src/modeling/solid/materials.jl 72.41% 24 Missing ⚠️
src/discretization/rsafdq-operator.jl 55.10% 22 Missing ⚠️
src/modeling/core/composite_elements.jl 36.36% 21 Missing ⚠️
ext/cuda/cuda_adapt.jl 0.00% 19 Missing ⚠️
ext/cuda/cuda_iterator.jl 0.00% 17 Missing ⚠️
src/solver/time/integrator/diffeq-interface.jl 50.00% 17 Missing ⚠️
ext/cuda/cuda_memalloc.jl 0.00% 16 Missing ⚠️
... and 52 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   71.70%   71.71%           
=======================================
  Files          78       78           
  Lines        6482     6515   +33     
=======================================
+ Hits         4648     4672   +24     
- Misses       1834     1843    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@kylebeggs kylebeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all just formatting changes right?

@termi-official
Copy link
Collaborator Author

this is all just formatting changes right?

And CI changes. Since you asked for this I need some guidance on what is actually needed here/if there is something missing.

@kylebeggs
Copy link
Collaborator

looks good otherwise

@kylebeggs
Copy link
Collaborator

I think this is good to go, but the merge is blocking because of the coverage. I'm fine with overriding it

@termi-official termi-official merged commit a07d127 into main Dec 9, 2025
8 of 9 checks passed
@termi-official termi-official deleted the do/precommit-check branch December 9, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .JuliaFormatter.toml

3 participants