Skip to content

Fail gracefully on some old tests #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonDanisch merged 2 commits into from
Apr 6, 2026
+22 −6
Merged

Fail gracefully on some old tests #431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0a8b6
fix: fail gracefully
icweaver Apr 4, 2026
eda7059
style: qualify RequestError
icweaver Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions test/query.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,17 +405,33 @@ let file_dir = joinpath(@__DIR__, "files"), file_path = Path(file_dir)
# q = query(f)
# @test typeof(q) <: File{format"MP4"}
end
function try_download(url)
try
return Downloads.download(url)
catch e
e isa Downloads.RequestError && return nothing
rethrow()
end
end
if Base.VERSION >= v"1.6" || !Sys.iswindows()
# FIXME: Windows fails to download the files on Julia 1.0
@testset "OGG detection" begin
f = Downloads.download("https://upload.wikimedia.org/wikipedia/commons/8/87/Annie_Oakley_shooting_glass_balls%2C_1894.ogv")
q = query(f)
@test typeof(q) <: File{format"OGG"}
tmpfile = try_download("https://upload.wikimedia.org/wikipedia/commons/8/87/Annie_Oakley_shooting_glass_balls%2C_1894.ogv")
if tmpfile == nothing
@test_skip "Skipped: network unavailable (download failed)"
else
q = query(tmpfile)
@test typeof(q) <: File{format"OGG"}
end
end
@testset "MATROSKA detection" begin
f = Downloads.download("https://upload.wikimedia.org/wikipedia/commons/1/13/Artist%E2%80%99s_impression_of_the_black_hole_inside_NGC_300_X-1_%28ESO_1004c%29.webm")
q = query(f)
@test typeof(q) <: File{format"MATROSKA"}
tmpfile = try_download("https://upload.wikimedia.org/wikipedia/commons/1/13/Artist%E2%80%99s_impression_of_the_black_hole_inside_NGC_300_X-1_%28ESO_1004c%29.webm")
if tmpfile == nothing
@test_skip "Skipped: network unavailable (download failed)"
else
q = query(tmpfile)
@test typeof(q) <: File{format"MATROSKA"}
end
end
end
@testset "WAV detection" begin
Expand Down
Loading