Skip to content

Load FileWatching before precompilepkgs in ensurecompiled #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 3 commits into from
Sep 24, 2026
Merged

Load FileWatching before precompilepkgs in ensurecompiled #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
818fb7d
Load `FileWatching` before `precompilepkgs` in `ensurecompiled`
KristofferC Sep 24, 2026
3ad6286
Shorten comments
KristofferC Sep 24, 2026
cf008e5
Test `ensurecompiled` directly instead of a full `create_sysimage`
KristofferC Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/PackageCompiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,10 @@ function ensurecompiled(project, packages, sysimage)
# Since Julia 1.11 Pkg is not in the sysimage, so under `--pkgimages=no`
# `Pkg.precompile()` has to JIT-compile all of Pkg (tens of seconds).
# Base.Precompilation is in the sysimage and does the actual work anyway.
# On Julia 1.11 `precompilepkgs` requires FileWatching to be loaded (for the
# pidlock), otherwise it silently compiles nothing (#1134).
code = isdefined(Base, :Precompilation) ?
"Base.Precompilation.precompilepkgs()" : "using Pkg; Pkg.precompile()"
"using FileWatching; Base.Precompilation.precompilepkgs()" : "using Pkg; Pkg.precompile()"
cmd = `$(get_julia_cmd()) --sysimage=$sysimage -e $code`
splitter = Sys.iswindows() ? ';' : ':'
@debug "ensurecompiled: running $cmd" JULIA_LOAD_PATH = "$project$(splitter)@stdlib"
Expand Down
27 changes: 27 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,33 @@ end
hello = read(`$(Base.julia_cmd()) -J $(sysimage_path) -e 'print("hello, world")'`, String)
@test hello == "hello, world"
end

# On Julia 1.11 `precompilepkgs` silently compiled nothing under the
# base sysimage, which does not contain FileWatching (#1134)
@testset "ensurecompiled under fresh base sysimage" begin
downloads_tmp = mktempdir()
write(joinpath(downloads_tmp, "Project.toml"), """
[deps]
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
""")
old_project = Base.ACTIVE_PROJECT[]
Base.ACTIVE_PROJECT[] = downloads_tmp
try
Pkg.instantiate()
finally
Base.ACTIVE_PROJECT[] = old_project
end
# reuses the base sysimage cached by the nonincremental builds above
base_sysimage = PackageCompiler.create_fresh_base_sysimage(; cpu_target="native", sysimage_build_args=``)
PackageCompiler.ensurecompiled(downloads_tmp, ["Downloads"], base_sysimage)
code = """
pkg = Base.PkgId(Base.UUID("f43a241f-c20a-4ad4-852c-f6b1247861c6"), "Downloads")
print(Base.isprecompiled(pkg))
"""
cmd = `$(PackageCompiler.get_julia_cmd()) --sysimage=$base_sysimage -e $code`
cmd = addenv(cmd, "JULIA_LOAD_PATH" => "$downloads_tmp$(Sys.iswindows() ? ';' : ':')@stdlib")
@test read(cmd, String) == "true"
end
end

@testset "Workspace bundling" begin
Expand Down
Loading