[tecosaur]

Transition from printstyled to the new approach to styling provided by StyledStrings.

Along the way, this makes it possible to restyle logging should you desire to do so (for whatever reason), but also means that you can inherit the colours used in logging in other places.

This requires JuliaLang/StyledStrings.jl#3 and JuliaLang/StyledStrings.jl#6 to be resolved first.

In the meantime, a bikeshedding opportunity: log.debug (et al.) vs. logging.debug (et al.)?

[tecosaur]

Good to merge after #51869.

[tecosaur]

Fixed the merge conflict introduced in #52196.

[tecosaur]

We could invoke StyledStrings.legacy_color to make @create_log_macro support colour numbers and old names, but since it's new API I'm not sure that this is needed.

[tecosaur]

I'm still interested in thoughts on

log.debug (et al.) vs. logging.debug (et al.)?

since I'm on the fence myself

[tecosaur]

Other than the aforementioned bikeshed, I think this is just a review short of merging?

[vtjnash]

Aside from needing to fix some tests, this LGTM

[vtjnash]

You have triage permissions, so you can tag your PRs with "merge me" whenever you get them to a point that is ready and with tests passing (which is slightly more prompt at getting noticed than the "awaiting review" tag)

[tecosaur]

• I'll bear merge me, in mind, I do like getting someone else's eyes on my code before merging though 🙂
• I've just pushed an updated runtests.jl for Logging that should be happy now 🤞
• I noticed that I forgot to update pkgimage.mk, and so have pushed an update to it too

[tecosaur]

Looking at the test state, it seems like we're good to go? Pkg isn't happy, but that seems to be that it has a bunch of test manifests that don't include StyledStrings as a dep of Logging, and they need to be updated.

I suspect I'm not the best person to take care of this Pkg-side issue.

[vtjnash]

I think that test was recently deleted from Pkg due to other bugs in that precompile test. But there is a test that you will need to update (it is a list of dependencies of things in some packages, for testing purposes that it can read those lists):

precompile                                        (1) |         failed at 2024-02-07T23:42:02.391
2024-02-07 18:42:02 EST	Test Failed at /cache/build/tester-amdci4-12/julialang/julia-master/julia-4e38ba77bc/share/julia/test/precompile.jl:475
2024-02-07 18:42:02 EST	  Expression: Dict(modules) == modules_ok

[tecosaur]

Ah right, thanks. I think I've adjusted modules_ok appropriately, we'll see how that goes 🤞.