Conversation
| "\\:arrow_right_hook:" => "↪", | ||
| "\\:arrow_up:" => "⬆", | ||
| "\\:arrow_up_down:" => "↕", | ||
| "\\:arrow_forward:" => "▶️", |
There was a problem hiding this comment.
Are we sure that we want the emoji rendering variant of these? I feel like for source code, the text rendering might be better.
There was a problem hiding this comment.
I updated the generation to prefer the older version if the completion contains "arrow".
There was a problem hiding this comment.
personally, I think it's clearer if we keep the \:name: syntax to mean the emoji version, and add a latex name like \bkuparrow(upwards black arrow) for the text version. that way it's more consistent
edit: actually we call the semantically very similar upwards white arrow \upwhitearrow, so these should be converted to variations on \upblackarrow.
|
@Keno Can you give this another review? |
|
Friendly ping. Let me know if new versions of other emoji patterns are not preferred. |
|
Bump @Keno - could you give this another review? |
DilumAluthge
added
status: waiting for PR reviewer
and removed
status: waiting for PR author
labels
In lieu of increasing page limit sizes split latex symbols from emojis. Done to fix JuliaLang#60263 Assisted-by: Claude Code (Opus 5)
| "\\:adult:" => "🧑", | ||
| "\\:aerial_tramway:" => "🚡", | ||
| "\\:airplane:" => "✈", | ||
| "\\:airplane:" => "✈️", |
There was a problem hiding this comment.
I guess the added FE0F is to ensure the render as emoji now instead of the older symbols?
| "\\:flag-ee:" => "🇪🇪", | ||
| "\\:flag-eg:" => "🇪🇬", | ||
| "\\:flag-eh:" => "🇪🇭", | ||
| "\\:flag-england:" => "🏴\Ue0067\Ue0062\Ue0065\Ue006e\Ue0067\Ue007f", |
There was a problem hiding this comment.
England, Scotland, and Wales have different unicode flags than all other countries? It does indeed render for me when printed. Any idea why it ends up printed this way here?
|
Does anyone else notice a significant delay backspacing the black flag after creating I guess it's because as Jameson noted it's many many characters? Kind of unergonomic |
vtjnash
added
merge me
|
Yes, it isn't a delay, but rather there's a lot of invisible characters after it |
| "https://raw.githubusercontent.com/iamcal/emoji-data/0f0cf4ea8845eb52d26df2a48c3c31c3b8cad14e/emoji_pretty.json", | ||
| "https://raw.githubusercontent.com/iamcal/emoji-data/e512953312c012f6bd00e3f2ef6bf152ca3710f8/emoji_pretty.json", | ||
| "https://raw.githubusercontent.com/iamcal/emoji-data/a8174c74675355c8c6a9564516b2e961fe7257ef/emoji_pretty.json", | ||
| "https://raw.githubusercontent.com/iamcal/emoji-data/3cf4d12c20b15ecdc53215b6b625b8515117aa93/emoji_pretty.json", |
There was a problem hiding this comment.
iamcal updated to unicode 17 on monday (just before the release of unicode 18 on wednesday), so this should be updated to 13ee711e222ea17fe537bfea953c687866f16411
|
(also my #61464 includes/supersedes the changes here) |
this pr combines changes from #61391 and #60263 into one single update. it: updates emoji completions to include v1️⃣7️⃣.0️⃣.0️⃣ adds completions for combining emoji 🇳🇱 enables reverse searching latex strings like \?arrowTab many of the text arrows updated to the \ufe0f version already had a latex version, added \*blackarrow to mimic \*whitearrow and new \curvearrow*s for the remaining ones Closes #56935
IanButterworth
removed
the
merge me
9 participants
No description provided.