Skip to content

Fix collect of non-reshaped reinterpret of an IndexSCartesian2 array #63352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jishnub merged 2 commits into from
Sep 26, 2026
Merged

Fix collect of non-reshaped reinterpret of an IndexSCartesian2 array #63352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec8129d
Fix collect of non-reshaped reinterpret of an IndexSCartesian2 array
greekera1000 Sep 25, 2026
db416f4
Use a whitelist of IndexStyles in non-reshaped reinterpret
greekera1000 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion base/reinterpretarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,10 @@ end
# `IndexStyle(a) == IndexLinear()`, it's advantageous to retain pseudo-linear indexing.
struct IndexSCartesian2{K} <: IndexStyle end # K = aligned_sizeof(S) ÷ aligned_sizeof(T), a static-sized 2d cartesian iterator

IndexStyle(::Type{ReinterpretArray{T,N,S,A,false}}) where {T,N,S,A<:AbstractArray{S,N}} = IndexStyle(A)
# only `IndexLinear` is known to be valid when the axes change (#63305)
IndexStyle(::Type{ReinterpretArray{T,N,S,A,false}}) where {T,N,S,A<:AbstractArray{S,N}} =
IndexStyle(A) === IndexLinear() ? IndexLinear() : IndexCartesian()

function IndexStyle(::Type{ReinterpretArray{T,N,S,A,true}}) where {T,N,S,A<:AbstractArray{S}}
if aligned_sizeof(T) < aligned_sizeof(S)
IndexStyle(A) === IndexLinear() && return IndexSCartesian2{aligned_sizeof(S) ÷ aligned_sizeof(T)}()
Expand Down
8 changes: 8 additions & 0 deletions test/reinterpretarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,3 +880,11 @@ end
@test !Base.array_subpadding(T_5, S_1_3)
@test !Base.array_subpadding(S_1_3, T_5)
end

@testset "issue #63305" begin
a = ones(UInt64, 2)
b = reinterpret(UInt8, reinterpret(reshape, UInt16, a))
c = collect(b)
@test c[5] == b[5] == 0x00
@test vec(c) == reinterpret(UInt8, a)
end
Loading