Repository navigation
Conversation
We also spritz it up a bit using the new StyledStrings library, namely: - colouring the Help and Pkg key prompts - making the docs link a terminal link, and Pkg a link to the Pkg docs - using box drawing characters for the dividing line - making branch status more colourful - making the official version text more subdued With these change the four banners (from smallest to largest) are: 1. A one-liner, for extreme circumstances (new) 2. The short banner 3. The large banner, with the description stacked vertically (new) 4. The large banner, with the description stacked horizontally This relands JuliaLang#51811, which was reverted (JuliaLang#59984) due to an `UnvefVarError` that was only hit on tagged releases. That has been fixed here. I have also found that printing the banner at startup compiled 11-16 methods, mostly `Dict{Tuple{Symbol, Any}, Int}` lookups that StyledStrings reaches through runtime dispatch, and the narrow, short, and tiny layouts that the precompile workload never rendered. The workload now renders every layout and precompiles those lookups.
tecosaur
added
REPL
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-land of #51811, with tagged releases fixed, some extra tests, and a minor styling tweak based on the last few comments in that PR.
TLDR; slightly prettified banner, and two extra banner variants for narrow and few-row sized windows, with the largest banner that fits in the current terminal window automatically selected by default.