Preserve argtup#168
Merged
Merged
Conversation
oscardssmith
approved these changes
Feb 8, 2026
ranocha
approved these changes
Feb 9, 2026
ranocha
left a comment
ranocha
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for the detailed analysis!
Contributor
Author
|
Running overnight (roughly 15 hours in total), without reproducing the bug. The nightly failure is unsettling since it means there is another memory management bug hidden somewhere... |
Member
|
Do you have an idea why two non-nightly CI jobs fail? |
Contributor
Author
Member
|
The same remaining CI failures also occur on the current release branch, see #171. Since this is the first time where "Julia 1" means Julia 1.12, fixing these additional failures is not required for merging this PR, which is already a strict improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Julia 1.12, we are observing occasional GC faults in Trixi.
An in-depth root-cause analysis is availalble here: trixi-framework/Trixi.jl#2766 (comment)
Short explanation: Polyester is laundering object references through void pointers (the taskpointer),
if one is not exceptionally careful in manually preserving the objects, references can be easily dropped.
The Trixi example fails for me in about 30-50 tries (30s per run so about half an hour),
running multiple parallel reproducers for several hours I am unable to hit the failure again with this patch.