fix(test): the f32 planar assertion must mirror planar_on() exactly - #1089
Merged
Merged
Conversation
The dev push CI failed on an AVX-512-VNNI runner: matmul_i4 takes the dot_i4f_avx512 arm there (different accumulation order), while the engine's planar gate deliberately keeps planar OFF on AVX-512F builds (#1086) — so the test asserted a claim the engine never makes. The PR run had passed on an AVX2-only runner: runner lottery, not a code change, flipped the result. The f32 comparison is now gated __AVX2__ && !(__AVX512F__&&__AVX512BW__), matching planar_on() to the letter, with a comment telling the story so the next gate change updates both places. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red dev push CI (Efficiency suite, 53s).
FAIL matmul_i4p f32 ... (avx512-vnni): the push run landed on an AVX-512-VNNI runner, wherematmul_i4takes thedot_i4f_avx512arm (different accumulation order) — while the engine's planar gate deliberately keeps planar off on AVX-512F builds (#1086). The test asserted the f32 equality under plain__AVX2__, i.e. a claim the engine never makes on that hardware. The PR run had passed because it drew an AVX2-only runner: runner lottery, not a code change, flipped the result.The comparison is now gated
__AVX2__ && !(__AVX512F__ && __AVX512BW__)—planar_on()to the letter — with a comment telling the story so the next gate change updates both places. 2,944 checks, 0 failures locally.Merge order note: this goes in before #1088 (K2), which is green by the same lottery and would stay exposed otherwise.
🤖 Generated with Claude Code