Fix household authentication on resume and VPN tracker advertisement - #180
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178 and fixes #179.
Restore the saved household key before reopening the donor TUI, so a restarted donor does not depend on shell credentials. Preserve the existing single AUTH exchange; the duplicate AUTH block described in #178 is not present in either main 231f83f or the cited 9434b77 commit. Regression tests now exercise a complete encrypted AUTH/OFFER exchange, reject wrong/missing/duplicate AUTH, and check saved-key activation.
Honor the existing LUMABRI_ADVERTISE IPv4 override when creating/resuming the household tracker. Persist that endpoint, reject malformed overrides without silently switching interfaces, keep exact household admission and peer identity checks, and return an actionable tracker-mismatch rejection. README documents the advanced override and restart requirement.
Validation passed locally: strict-warning TUI build; encrypted monitor/auth/admission tests; network/address validation; real tracker PTY create/attach/restart/discovery/join; complete resident household flow with two executing donors and one donor started without LUMABRI_TOKEN in its environment, followed by a source-offline second chat with no weight mirror writes. Added encrypted admission coverage to native macOS CI. Physical Tailscale reproduction by the reporter remains to be confirmed; no native macOS or Windows claim from the local Linux run.