[No QA] Remove redundant type assertions from test suites - #2
Closed
KJ21-ENG wants to merge 10000 commits into
Closed
[No QA] Remove redundant type assertions from test suites#2KJ21-ENG wants to merge 10000 commits into
KJ21-ENG wants to merge 10000 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[No QA] Remove redundant type assertions from test suites
Explanation of Change
This test-only cleanup removes redundant unsafe type assertions from ten
existing test suites. It replaces them with production-derived signatures and
repository-native typed fixtures while preserving each test scenario and
runtime behavior. The MFA mock retains a typed forwarding wrapper so Jest's
hoisted module factory exposes a callable export.
Fixed Issues
$ Expensify#94739
PROPOSAL: Expensify#94739
Tests
lint, format, React compiler, and targeted Jest.
Offline tests
Not applicable: this PR changes test typing only and no product runtime code.
QA Steps
No QA required for this test-only cleanup.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos