-
Notifications
You must be signed in to change notification settings - Fork 37
Add usage instructions for mise #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
alternative install for those not in the node ecosystem
Summary of ChangesHello @drewwells, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's accessibility by providing an alternative installation and usage method for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds usage instructions for mise as an alternative to npx. My review suggests improving the new instructions by using the mise x command, which is a more direct equivalent to npx, and by adding a brief introductory sentence for better context.
|
|
||
| ```bash | ||
| mise use npm:speed-cloudflare-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding mise usage instructions. I have a couple of suggestions to improve them:
- It would be clearer to add a short introductory sentence to explain that this is an alternative way to run the tool.
- The
mise usecommand is not a direct equivalent ofnpx.mise useonly makes the tool available in the current shell, requiring the user to runspeed-cloudflare-clias a second step. For a one-shot execution similar tonpx,mise xis the recommended command.
My suggestion below applies both of these changes.
| ```bash | |
| mise use npm:speed-cloudflare-cli | |
| Or, using [mise](https://mise.jdx.dev/): | |
| ```bash | |
| mise x -- npm:speed-cloudflare-cli |
alternative install for those not in the node ecosystem