Drop JsonPoke requirement for version-file generation#52
Drop JsonPoke requirement for version-file generation#52Twinki14 wants to merge 2 commits intoKSPModdingLibs:mainfrom
Conversation
|
I like it, especially because I think jsonpoke isn’t available for non-sdk projects. I’ll have to go over it in more detail and hopefully drew can take a look too since he set that stuff up initially. |
|
Looks like this only generates the json? it cant modify an existing version file? |
No, EDIT: Let me know if you agree with this PR or not, I'll resolve the conflicts. Personally IMO, don't depend on |
Motivations
JsonPoke isn't technically required, and while it is beneficial to use something that's specifically meant for JSON file writing, we don't really need it.
Modifications
WriteLinesToFile. This did require a little hacky fix for proper indention, but it's not that hacky in my opinion. WhileWriteLinesToFiledoesn't specifically support writing JSON, we aren't really writing much JSON in the first place.Results