Fixes #39728 - Migrate Manifest History table from PF3 to PF5 - #11804
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough
ChangesManifest modal migration
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ManageManifestModal
participant ManifestTabContent
participant ManifestHistoryContent
participant CdnTabContent
ManageManifestModal->>ManifestTabContent: Render manifest state and actions
ManageManifestModal->>ManifestHistoryContent: Render loading, empty, or history table state
ManageManifestModal->>CdnTabContent: Render CDN configuration
ManifestTabContent->>ManageManifestModal: Invoke upload, refresh, or delete callback
CdnTabContent->>ManageManifestModal: Invoke configuration update callback
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webpack/scenes/Subscriptions/Manifest/ManageManifestModal.js`:
- Around line 37-45: Consolidate the duplicated tab-visibility derivation in the
component: compute showSubscriptionManifest and showManifestTab once before
useState, pass the resulting showManifestTab into getDefaultTabKey, and reuse
both values for the JSX render guards. Update getDefaultTabKey to consume the
precomputed visibility rather than recomputing permission logic, keeping default
selection and rendered tabs synchronized.
- Around line 75-83: Update the row identity in the manifestHistory.results.map
rendering to use a collision-resistant value that remains unique for duplicate
records, such as incorporating the map index alongside the existing fields, and
apply the same identity consistently to both the React key and ouiaId on each
Tr.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 72d25dbd-b3fb-4bf3-af3b-32a4dc51fec4
📒 Files selected for processing (4)
webpack/scenes/Subscriptions/Manifest/ManageManifestModal.jswebpack/scenes/Subscriptions/Manifest/ManageManifestModal.scsswebpack/scenes/Subscriptions/Manifest/ManifestHistoryTableSchema.jswebpack/scenes/Subscriptions/Manifest/__tests__/ManageManifestModal.test.js
💤 Files with no reviewable changes (1)
- webpack/scenes/Subscriptions/Manifest/ManifestHistoryTableSchema.js
MariaAga
reviewed
Jul 31, 2026
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
webpack/scenes/Subscriptions/Manifest/ManifestHistoryContent.js (1)
51-55: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider a more precise
resultsshape.
resultsis typed asPropTypes.arrayOf(PropTypes.shape({})), an empty shape. Declare thestatus,statusMessage, andcreatedfields actually used at Lines 41-43. This documents the contract and helps catch a mismatch at development time.♻️ Proposed refactor
ManifestHistoryContent.propTypes = { manifestHistory: PropTypes.shape({ - results: PropTypes.arrayOf(PropTypes.shape({})), + results: PropTypes.arrayOf(PropTypes.shape({ + status: PropTypes.string, + statusMessage: PropTypes.string, + created: PropTypes.string, + })), }).isRequired, };🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@webpack/scenes/Subscriptions/Manifest/ManifestHistoryContent.js` around lines 51 - 55, Update the manifestHistory prop type in ManifestHistoryContent.propTypes so results uses a precise PropTypes.shape declaring the status, statusMessage, and created fields consumed by the component, replacing the empty shape while preserving the existing array contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webpack/scenes/Subscriptions/Manifest/ManifestTabContent.js`:
- Around line 69-73: Update uploadManifest and its file-selection handler to
clear the native file input value after reading the selected file list, while
preserving the existing upload(fileList[0]) behavior. Reset e.target.value after
initiating the upload so selecting the same file again triggers onChange,
including the alternate occurrence noted in the comment.
- Around line 62-67: Update disabledTooltipText to check actionInProgress
instead of taskInProgress, matching the Delete button’s disabled condition and
ensuring manifestActionStarted reports the in-progress task reason.
---
Nitpick comments:
In `@webpack/scenes/Subscriptions/Manifest/ManifestHistoryContent.js`:
- Around line 51-55: Update the manifestHistory prop type in
ManifestHistoryContent.propTypes so results uses a precise PropTypes.shape
declaring the status, statusMessage, and created fields consumed by the
component, replacing the empty shape while preserving the existing array
contract.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: df83006a-496a-4e9a-a493-33d80b011693
📒 Files selected for processing (5)
webpack/scenes/Subscriptions/Manifest/CdnTabContent.jswebpack/scenes/Subscriptions/Manifest/ManageManifestModal.jswebpack/scenes/Subscriptions/Manifest/ManageManifestModalConstants.jswebpack/scenes/Subscriptions/Manifest/ManifestHistoryContent.jswebpack/scenes/Subscriptions/Manifest/ManifestTabContent.js
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
MariaAga
suggested changes
Aug 11, 2026
Lukshio
force-pushed
the
manifestUpdate
branch
from
August 18, 2026 10:20
12e91f6 to
3e98542
Compare
Contributor
Author
|
I am wondering if the linter is setup correctly, because this should be fine |
MariaAga
suggested changes
Aug 19, 2026
Lukshio
force-pushed
the
manifestUpdate
branch
from
August 24, 2026 12:22
6e780fd to
e6e9e76
Compare
pondrejk
approved these changes
Sep 1, 2026
pondrejk
left a comment
pondrejk
left a comment
Contributor
There was a problem hiding this comment.
Checked from the functional side using packit build, I consider this good to go
Contributor
|
I have linked this PR to https://projects.theforeman.org/issues/39728 , commits and title should be updated (#39444 is closed) |
LadislavVasina1
approved these changes
Sep 4, 2026
LadislavVasina1
left a comment
LadislavVasina1
left a comment
Contributor
There was a problem hiding this comment.
I also checked this PR from the functional side and it looks good to me.
Lukshio
force-pushed
the
manifestUpdate
branch
from
September 4, 2026 13:27
e6e9e76 to
341753d
Compare
Lukshio
changed the title
Contributor
Author
|
@pavanshekar Commits squashed and updated redmine issue number |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest History tab
Modal layout and tabs
Component structure
Before:
After
Summary by CodeRabbit