Fix evaluation count in PyATF search strategies #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search strategies from PyATF are not guaranteed to always give a unique point. It is possible that `get_next_coordinates` actually returns the same configurations multiple times. However, these should not count towards the evaluation limit (`max_feval`). This commit makes it so that only unique configuration evaluations are counted towards the limit.
stijnh
force-pushed
the
pyatf-eval-count-fix
branch
from
b45ded8 to
e1a42eb
Compare
…tf-eval-count-fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search strategies from PyATF are not guaranteed to always give a unique point. It is possible that
get_next_coordinatesactually returns the same configurations multiple times. However, these should not count towards the evaluation limit (max_feval).This commit makes it so that only unique configuration evaluations are counted towards the limit.