fix: show actual parse error in queue validation failure message#285
Open
airouboss wants to merge 1 commit intoKeygraphHQ:mainfrom
Open
fix: show actual parse error in queue validation failure message#285airouboss wants to merge 1 commit intoKeygraphHQ:mainfrom
airouboss wants to merge 1 commit intoKeygraphHQ:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a queue file contains invalid JSON, the error logged was always the
same generic message with no detail about what was actually wrong. The real
parse error was being captured but silently dropped, so you'd have to dig
into error context objects to figure out what the agent produced.
This change includes the actual parse error in the message so it shows up
directly in logs.
Since the project didn't have a test setup yet, I added vitest and wrote
13 tests covering the full validation pipeline, missing files, malformed
JSON, wrong structure, empty queues, and populated queues.