Update accessibility criteria for Grapher#3854
Merged
Merged
Conversation
Contributor
|
Size Change: +29 B (+0.01%) Total Size: 517 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (3262a1c) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3854If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3854If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3854 |
catandthemachines
approved these changes
Jul 2, 2026
catandthemachines
left a comment
catandthemachines
left a comment
Member
There was a problem hiding this comment.
Looks great! Just one suggestion.
| availableTypes: ["linear"], | ||
| }); | ||
|
|
||
| it("returns true when the graph is accessible", () => { |
Member
There was a problem hiding this comment.
Can you state what makes grapher accessible in this case? It'll help differentiate it from the other true case below.
benchristel
force-pushed
the
benc/accessible-grapher
branch
from
6ebdeb5 to
e91792d
Compare
the count of lint issues changed because Grapher is now accessible.
…marked **accessible** if it has a single available function type that is not `quadratic`, and no background image.
Merged
benchristel
pushed a commit
that referenced
this pull request
Jul 6, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-core@30.1.0 ### Minor Changes - [#3854](#3854) [`4306c90`](4306c90) Thanks [@benchristel](https://github.com/benchristel)! - The Grapher widget is now marked **accessible** if it has a single available function type that is not `quadratic`, and no background image. ### Patch Changes - [#3859](#3859) [`eec5371`](eec5371) Thanks [@benchristel](https://github.com/benchristel)! - The now-unused feature flag "input-number-to-numeric-input" has been removed. - [#3855](#3855) [`8d25dbd`](8d25dbd) Thanks [@benchristel](https://github.com/benchristel)! - The `grapher-to-interactive-graph` feature flag has been removed. Graphers now render as Interactive Graphs if they have a single available function type that is not `quadratic`. ## @khanacademy/keypad-context@3.2.71 ### Patch Changes - Updated dependencies \[[`eec5371`](eec5371), [`4306c90`](4306c90), [`8d25dbd`](8d25dbd)]: - @khanacademy/perseus-core@30.1.0 ## @khanacademy/kmath@2.4.30 ### Patch Changes - Updated dependencies \[[`eec5371`](eec5371), [`4306c90`](4306c90), [`8d25dbd`](8d25dbd)]: - @khanacademy/perseus-core@30.1.0 ## @khanacademy/math-input@26.4.44 ### Patch Changes - Updated dependencies \[[`eec5371`](eec5371), [`4306c90`](4306c90), [`8d25dbd`](8d25dbd)]: - @khanacademy/perseus-core@30.1.0 - @khanacademy/keypad-context@3.2.71 ## @khanacademy/perseus@79.1.2 ### Patch Changes - [#3847](#3847) [`855f36d`](855f36d) Thanks [@Evelas78](https://github.com/Evelas78)! - Regression tests for sorter - [#3802](#3802) [`45feb6d`](45feb6d) Thanks [@Evelas78](https://github.com/Evelas78)! - Added multiple regression tests for the radio widget - [#3812](#3812) [`53b4221`](53b4221) Thanks [@nishasy](https://github.com/nishasy)! - [ColorSync][numeric input] Add more regression stories for the Numeric Input widget - [#3859](#3859) [`eec5371`](eec5371) Thanks [@benchristel](https://github.com/benchristel)! - The now-unused feature flag "input-number-to-numeric-input" has been removed. - [#3855](#3855) [`8d25dbd`](8d25dbd) Thanks [@benchristel](https://github.com/benchristel)! - The `grapher-to-interactive-graph` feature flag has been removed. Graphers now render as Interactive Graphs if they have a single available function type that is not `quadratic`. - [#3835](#3835) [`e5c4c92`](e5c4c92) Thanks [@jandrade](https://github.com/jandrade)! - Migrate Wonder Blocks font sizing from the deprecated `font.size` / `--wb-font-size` tokens to the newer `font.body.size` / `--wb-font-body-size` tokens. Sizes that have no `body` equivalent (`large`) now use the matching `font.heading.size` token. - Updated dependencies \[[`eec5371`](eec5371), [`4306c90`](4306c90), [`8d25dbd`](8d25dbd)]: - @khanacademy/perseus-core@30.1.0 - @khanacademy/keypad-context@3.2.71 - @khanacademy/kmath@2.4.30 - @khanacademy/math-input@26.4.44 - @khanacademy/perseus-linter@5.1.11 - @khanacademy/perseus-score@8.12.3 ## @khanacademy/perseus-editor@34.1.2 ### Patch Changes - [#3832](#3832) [`4f11360`](4f11360) Thanks [@nishasy](https://github.com/nishasy)! - Put the left and right sides of the editor in separate scroll areas - [#3828](#3828) [`ffc1dcd`](ffc1dcd) Thanks [@catandthemachines](https://github.com/catandthemachines)! - [Interactive Graph][editor] Fix invariant error in interactve graph editor. - [#3835](#3835) [`e5c4c92`](e5c4c92) Thanks [@jandrade](https://github.com/jandrade)! - Migrate Wonder Blocks font sizing from the deprecated `font.size` / `--wb-font-size` tokens to the newer `font.body.size` / `--wb-font-body-size` tokens. Sizes that have no `body` equivalent (`large`) now use the matching `font.heading.size` token. - Updated dependencies \[[`855f36d`](855f36d), [`45feb6d`](45feb6d), [`53b4221`](53b4221), [`eec5371`](eec5371), [`4306c90`](4306c90), [`8d25dbd`](8d25dbd), [`e5c4c92`](e5c4c92)]: - @khanacademy/perseus@79.1.2 - @khanacademy/perseus-core@30.1.0 - @khanacademy/keypad-context@3.2.71 - @khanacademy/kmath@2.4.30 - @khanacademy/math-input@26.4.44 - @khanacademy/perseus-linter@5.1.11 ## @khanacademy/perseus-linter@5.1.11 ### Patch Changes - Updated dependencies \[[`eec5371`](eec5371), [`4306c90`](4306c90), [`8d25dbd`](8d25dbd)]: - @khanacademy/perseus-core@30.1.0 - @khanacademy/kmath@2.4.30 ## @khanacademy/perseus-score@8.12.3 ### Patch Changes - Updated dependencies \[[`eec5371`](eec5371), [`4306c90`](4306c90), [`8d25dbd`](8d25dbd)]: - @khanacademy/perseus-core@30.1.0 - @khanacademy/kmath@2.4.30 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ 11 checks were successful Pull Request URL: #3861
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Grapher widget is now accessible if:
quadraticThis is because we use the Interactive Graph UI components for Graphers that
aren't quadratic or choose-your-own-function. Graphers with background images
are not accessible because they don't have alt text.
Issue: https://khanacademy.atlassian.net/browse/LEMS-4289
Test plan:
Deploy. Graphers in the content editor should not display an accessibility
lint warning if they meet the criteria above.