Add cloud storage ids for projects#10808
Merged
lee-at-zoo-corp merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will not alter performance
Comparing Footnotes
|
683de08 to
ea91745
Compare
ea91745 to
39c1e2e
Compare
39c1e2e to
1e6930b
Compare
1e6930b to
30ad336
Compare
30ad336 to
baea5a4
Compare
baea5a4 to
10c1acb
Compare
10c1acb to
92544c1
Compare
iterion
commented
Apr 9, 2026
| ```toml | ||
| [settings.app] | ||
| # Set the appearance of the application | ||
| name = "My Awesome Project" |
Contributor
Author
There was a problem hiding this comment.
This never existed in the schema, so I'm not sure where it's coming from. This came from regenerating docs locally.
If we upload the KCL, we want to keep track of that so we can easily update the project again in the future. Not 100% dedicated to the names here, nothing concrete has landed so we can change it.
92544c1 to
e24228a
Compare
lee-at-zoo-corp
approved these changes
Apr 9, 2026
Contributor
lee-at-zoo-corp
left a comment
There was a problem hiding this comment.
automatic merge behavior when the same local meta.id appears in multiple places
Maybe even preferable to never do it, since meta.id is user controlled!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we upload the KCL, we want to keep track of that so we can easily update the project again in the future.
What is getting added?
To account for our internal usage of multiple environments, we track cloud project id per environment:
Most folks will only ever interact with one environment, but for us, that's a pretty common use case. Because of this, we want to make sure that our way of working is not impacted, insofar as we can upload/download from any environment.
Why not reuse
meta.id?meta.idis a locally generated id and it serves as a good artifact of that local or shared lineage. None of our APIs currently accept customer generated ids, and we do that so the API remains the source of truth. Because these are IDs in our database it should be in charge of issuing valid values.For now, we accept that this could lead to some drift between environments.
Not in scope for this PR
Expected workflow from ZDS/CLI
flowchart TD subgraph ZDS[ZDS] A[User clicks Share / Upload] B[Read local project.toml] C[Determine active API environment] D{cloud.env.project_id present?} E[Choose Create request] F[Choose Update request] G[Write cloud.env.project_id to project.toml] H[Leave other cloud.other-env bindings unchanged] end subgraph API[API] I[Receive create request] J[Upload current project files] K[Create DB record in active environment] L[Return success + remote project_id] M[Receive update request] N[Upload current project files] O[Update DB record for existing remote project_id] P[Return success] end A --> B B --> C C --> D D -- No --> E E --> I I --> J J --> K K --> L L --> G G --> H D -- Yes --> F F --> M M --> N N --> O O --> P P --> HRelates to https://github.com/KittyCAD/roadmap/issues/296
Prereq for #10903